Last modified: 2014-04-10 23:29:58 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T65791, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 63791 - VisualEditor: Faulty wmf21 OOjs UI deploy -> Exception on load "Uncaught TypeError: Object #<Object> has no method 'lookup'"
VisualEditor: Faulty wmf21 OOjs UI deploy -> Exception on load "Uncaught Type...
Status: RESOLVED FIXED
Product: VisualEditor
Classification: Unclassified
Editing Tools (Other open bugs)
unspecified
All All
: Highest normal
: ---
Assigned To: Krinkle
:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2014-04-10 21:44 UTC by Rummana Yasmeen
Modified: 2014-04-10 23:29 UTC (History)
6 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Rummana Yasmeen 2014-04-10 21:44:51 UTC 
After wmf21 deployment cannot load VE on en.wiki.GEtting the following error:

Uncaught TypeError: Object #<Object> has no method 'lookup' VM734:1505
Comment 1 Ed Sanders 2014-04-10 21:57:40 UTC 
oojs-ui was pulled through to MW core with a breaking change ( https://gerrit.wikimedia.org/r/#/c/121537/ ) before the update to VE extension.

It was correctly pulled through to ve core with changes: https://gerrit.wikimedia.org/r/#/c/120844/
Comment 2 Trevor Parscal 2014-04-10 22:13:59 UTC 
Uncaught TypeError: Object #<Object> has no method 'lookup' VM1319:1505
OO.ui.Toolbar.setup VM1319:1505
ve.init.mw.Target.setUpToolbar VM1319:19180
ve.init.mw.ViewPageTarget.setUpToolbar VM1319:21943
(anonymous function)
Comment 3 Krinkle 2014-04-10 22:16:18 UTC 
Looks like Rummana and Trevor can reproduce it on their machine, but Ed and myself cannot.

And on their machine it also doesn't happen in Incognito mode, so looks like it is a caching bug.

-- 
[#wikimedia-operations]
 !log krinkle touched php-1.23wmf21/resources/oojs-ui/oojs-ui.js'
 !log krinkle touched php-1.23wmf21/resources/startup.js
 !log krinkle touched php-1.23wmf21/extensions/VisualEditor/lib/ve/lib/oojs-ui/oojs-ui.js
 !log krinkle touched php-1.23wmf21/extensions/VisualEditor/lib/ve/modules/ve/ui/ve.ui.Toolbar.js
Comment 4 Ed Sanders 2014-04-10 22:31:51 UTC 
Looks like a caching issue.

The offending line is 25 of ve.ui.Toolbar.js

Fixed by Timo
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links