Last modified: 2014-06-02 11:30:25 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T65725, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 63725 - Large number of CSS rules for external links
Large number of CSS rules for external links
Status: NEW
Product: Wikimedia
Classification: Unclassified
General/Unknown (Other open bugs)
unspecified
All All
: Normal normal (vote)
: ---
Assigned To: Nobody - You can work on this!
: performance
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-04-09 13:01 UTC by Nemo
Modified: 2014-06-02 11:30 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
Output of: mwgrep external --max-results 1000 | grep '.css$' (18.57 KB, text/plain)
2014-04-09 13:43 UTC, Marius Hoch
Details

Description Nemo 2014-04-09 13:01:37 UTC
1) Wikimedia wikis{{which}} have{{citation needed}} a large{{vague}} number of CSS rules for external links (icons);
2) this is a problem{{vague}}, also for performance.{{citation needed}}

Hoo (or another shell user), can you please help us verify (1) by running [[wikitech:mwgrep]]? "mwgrep external" may be enough; if it's too noisy, I guess [[MediaWiki:Common.css]] can give suggestions as well.

Discussing (2) is out of scope for this bug: go to bug 54604 instead for that.
Comment 1 Marius Hoch 2014-04-09 13:43:21 UTC
Created attachment 15066 [details]
Output of: mwgrep external --max-results 1000 | grep '.css$'
Comment 2 Bawolff (Brian Wolff) 2014-04-09 14:15:34 UTC
(In reply to Nemo from comment #0)
> 1) Wikimedia wikis{{which}} have{{citation needed}} a large{{vague}} number
> of CSS rules for external links (icons);
> 2) this is a problem{{vague}}, also for performance.{{citation needed}}
> 
> Hoo (or another shell user), can you please help us verify (1) by running
> [[wikitech:mwgrep]]? "mwgrep external" may be enough; if it's too noisy, I
> guess [[MediaWiki:Common.css]] can give suggestions as well.
> 
> Discussing (2) is out of scope for this bug: go to bug 54604 instead for
> that.

My reading of the other bug is a complaint about css rules in core mediawiki skin files, not css rules in wiki css.
Comment 3 Nemo 2014-04-09 14:34:41 UTC
(In reply to Bawolff (Brian Wolff) from comment #2)
> My reading of the other bug is a complaint about css rules in core mediawiki
> skin files, not css rules in wiki css.

Sure, that's why I filed a separate one for Wikimedia wikis. :) Or are you saying that such CSS rules are more efficient when placed in wiki CSS?
Comment 4 Bawolff (Brian Wolff) 2014-04-09 14:40:43 UTC
(In reply to Nemo from comment #3)
> (In reply to Bawolff (Brian Wolff) from comment #2)
> > My reading of the other bug is a complaint about css rules in core mediawiki
> > skin files, not css rules in wiki css.
> 
> Sure, that's why I filed a separate one for Wikimedia wikis. :) Or are you
> saying that such CSS rules are more efficient when placed in wiki CSS?

Oh. Sorry I misunderstood why you were filing this. Carry on. :)

(I take no position on the css link rule thing. I honestly have no idea. Somebody should probably profile it (is there profiling tools for css? I dont even know). Premature optimization is the root of all evil and all that)
Comment 5 Nemo 2014-04-10 09:48:29 UTC
(In reply to Marius Hoch from comment #1)
> Created attachment 15066 [details]
> Output of: mwgrep external --max-results 1000 | grep '.css$'

Oh well, that's a juniper thicket in any case (we'd say in Italian); I sent them all a notice and they'll decide what to do if anything.
https://meta.wikimedia.org/w/index.php?title=Special:Log/massmessage&dir=prev&offset=20140408175303&limit=1&type=massmessage&user=
Now let's listen. :)

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links