Last modified: 2014-07-01 20:34:48 UTC
Some icons need to be flipped for RTL languages. Here's what I found till now: In lib/ve/lib/oojs-ui/images/icons: * help.svg - This is a question mark in a circle. This should be flipped for all RTL languages, but *not* for Hebrew (he) and Yiddish (yi). In lib/ve/modules/ve/ui/styles/images/icons: * external-link.svg In modules/ve-mw/ui/styles/images/icons: * gallery.svg * parameter.svg * parameter-set.svg * ref-cite-book.svg * ref-cite-journal.svg * ref-cite-news.svg * reference.svg * references.svg
(In reply to Amir E. Aharoni from comment #0) > Some icons need to be flipped for RTL languages. Here's what I found till > now: > > In lib/ve/lib/oojs-ui/images/icons: > * help.svg - This is a question mark in a circle. This should be flipped for > all RTL languages, but *not* for Hebrew (he) and Yiddish (yi). This should (a) be an OOUI bug, and (b) is really quite hard for us to do as our build system only supports LTR or RTL, it doesn't do language-specific builds. How high priority is this? > In lib/ve/modules/ve/ui/styles/images/icons: > * external-link.svg Not currently used, but done in Gerrit change #143240. > In modules/ve-mw/ui/styles/images/icons: > * gallery.svg > * parameter.svg > * parameter-set.svg > * ref-cite-journal.svg > * ref-cite-news.svg > * reference.svg > * references.svg Done in Gerrit change #143241. > * ref-cite-book.svg Not now needed (no LTR/RTL variance). Similarly for ref-cite-web.
(In reply to James Forrester from comment #1) > (In reply to Amir E. Aharoni from comment #0) > > Some icons need to be flipped for RTL languages. Here's what I found till > > now: > > > > In lib/ve/lib/oojs-ui/images/icons: > > * help.svg - This is a question mark in a circle. This should be flipped for > > all RTL languages, but *not* for Hebrew (he) and Yiddish (yi). > > This should (a) be an OOUI bug, and (b) is really quite hard for us to do as > our build system only supports LTR or RTL, it doesn't do language-specific > builds. How high priority is this? Pretty important for people who write Arabic, Persian and Urdu. Can't it be done the same way it's done for Bold and Italic?
(In reply to Amir E. Aharoni from comment #2) > (In reply to James Forrester from comment #1) > > (In reply to Amir E. Aharoni from comment #0) > > > Some icons need to be flipped for RTL languages. Here's what I found till > > > now: > > > > > > In lib/ve/lib/oojs-ui/images/icons: > > > * help.svg - This is a question mark in a circle. This should be flipped for > > > all RTL languages, but *not* for Hebrew (he) and Yiddish (yi). > > > > This should (a) be an OOUI bug, and (b) is really quite hard for us to do as > > our build system only supports LTR or RTL, it doesn't do language-specific > > builds. How high priority is this? > > Pretty important for people who write Arabic, Persian and Urdu. > Can't it be done the same way it's done for Bold and Italic? No; OOUI only understands RTL and LTR, not specific languages. The bold icon isn't from OOUI but from VE itself, which does. Oy.
(In reply to James Forrester from comment #3) > No; OOUI only understands RTL and LTR, not specific languages. The bold icon > isn't from OOUI but from VE itself, which does. Oy. Actually the per-language icon format is in OOUI (IconedElement.js line 42). You need to define the language overrides every time you specify the icon instead of just making it a 'feature' of the icon like directionality.
(In reply to Ed Sanders from comment #4) > (In reply to James Forrester from comment #3) > > No; OOUI only understands RTL and LTR, not specific languages. The bold icon > > isn't from OOUI but from VE itself, which does. Oy. > > Actually the per-language icon format is in OOUI (IconedElement.js line 42). > You need to define the language overrides every time you specify the icon > instead of just making it a 'feature' of the icon like directionality. Oh, interesting. OK, so we'd need to use that in downstream tools if particular languages want over-rides? Ick. See Gerrit change #143407 for the easy part.
