Last modified: 2014-08-28 14:27:15 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T65521, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 63521 - Default external link icons should be a module
Default external link icons should be a module
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
Interface (Other open bugs)
1.23.0
All All
: Normal enhancement (vote)
: 1.24.0 release
Assigned To: Nobody - You can work on this!
: design
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2014-04-04 14:49 UTC by Isarra
Modified: 2014-08-28 14:27 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Isarra 2014-04-04 14:49:23 UTC 
A module should be created with default external link icons and styling so that skins using a standard styling (using, compatible with, or similar to commonelements etc) don't need to reimplement and duplicate the entire external links styling out of another skin.

Ideally this common module would replace the external link icons in both monobook and vector, as well as myriad custom skins, thus making it much easier to maintain this aspect of skins.
Comment 1 Bartosz Dziewoński 2014-04-07 10:21:43 UTC 
Note that the icons in Vector have been very recently removed (I don't have a commit link handy, sorry).
Comment 2 Isarra 2014-04-07 14:46:29 UTC 
In reply to Bartosz Dziewoński from comment #1)
> Note that the icons in Vector have been very recently removed (I don't have
> a commit link handy, sorry).

Odd. Bug 54604 suggested that consensus was rather against that.
Comment 3 Gerrit Notification Bot 2014-07-01 15:50:59 UTC 
Change 143173 had a related patch set uploaded by Isarra:
New ResourceLoader module for external links to facilitate the creation of third-party skins.

https://gerrit.wikimedia.org/r/143173
Comment 4 Gerrit Notification Bot 2014-08-28 14:24:31 UTC 
Change 143173 merged by jenkins-bot:
Introduce mediawiki.skinning module for external link icons

https://gerrit.wikimedia.org/r/143173
Comment 5 Bartosz Dziewoński 2014-08-28 14:27:15 UTC 
Whee~
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links