Last modified: 2014-04-09 09:34:14 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T65449, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 63449 - Add musees.cg70.fr to $wgCopyUploadsDomains for Commons for GWToolset
Add musees.cg70.fr to $wgCopyUploadsDomains for Commons for GWToolset
Status: RESOLVED FIXED
Product: Wikimedia
Classification: Unclassified
Site requests (Other open bugs)
wmf-deployment
All All
: Normal enhancement (vote)
: ---
Assigned To: Jean-Fred
: shell
Depends on:
Blocks: 58224
  Show dependency treegraph
 
Reported: 2014-04-02 21:56 UTC by Jean-Fred
Modified: 2014-04-09 09:34 UTC (History)
9 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Jean-Fred 2014-04-02 21:56:36 UTC
Please add the following domain(s) to the wgCopyUploadsDomains whitelist:
http://musees.cg70.fr

This is part of a GLAM batch upload using the GlamWiki Toolset
<https://commons.wikimedia.beta.wmflabs.org/wiki/Special:GWToolset>

This supersedes bug:61378

I’ll submit a patch in a sec.
Comment 1 Bawolff (Brian Wolff) 2014-04-02 22:03:27 UTC
Given that gwtoolset is severely limitted to who can use it, could we just make it ignore the whitelist, or would that be a big no no? (Asked to nobody in particular)
Comment 2 Gerrit Notification Bot 2014-04-02 22:04:37 UTC
Change 123459 had a related patch set uploaded by Jean-Frédéric:
Add Musées de la Haute-Saône to wgCopyUploadsDomains

https://gerrit.wikimedia.org/r/123459
Comment 3 Jean-Fred 2014-04-07 09:14:01 UTC
Sorry to be bugging, but could this be merged soonish? Our partners are operating on a very tight schedule here, so we need to get things started in the coming week(s).
Comment 4 Gerrit Notification Bot 2014-04-07 23:14:20 UTC
Change 123459 merged by jenkins-bot:
Add Musées de la Haute-Saône to wgCopyUploadsDomains

https://gerrit.wikimedia.org/r/123459
Comment 5 Jean-Fred 2014-04-08 16:11:16 UTC
Thanks Roan for deploying this.

We encountered the following error though:

Copy uploads are not available from this domain. original URL: http://musees.cg70.fr/wikimedia/2006/DV5_M0354_2006_7/DV5_M0354_2006_7_tif/M0354_2-047-57_1.tif evaluated URL: http://musees.cg70.fr/wikimedia/2006/DV5_M0354_2006_7/DV5_M0354_2006_7_tif/M0354_2-047-57_1.tif

(on the Beta cluster)

Does that mean that http://musees.cg70.fr/* does not get whitelisted by *.musees.cg70.fr?

I followed the way other domain names were whitelisted, assuming it was the right way to do it...

(Reopening for the discussion, please let me know if this is not the right venue).
Comment 6 Bawolff (Brian Wolff) 2014-04-08 18:24:02 UTC
(In reply to Jean-Fred from comment #5)
> Thanks Roan for deploying this.
> 
> We encountered the following error though:
> 
> Copy uploads are not available from this domain. original URL:
> http://musees.cg70.fr/wikimedia/2006/DV5_M0354_2006_7/DV5_M0354_2006_7_tif/
> M0354_2-047-57_1.tif evaluated URL:
> http://musees.cg70.fr/wikimedia/2006/DV5_M0354_2006_7/DV5_M0354_2006_7_tif/
> M0354_2-047-57_1.tif
> 
> (on the Beta cluster)
> 
> Does that mean that http://musees.cg70.fr/* does not get whitelisted by
> *.musees.cg70.fr?

Possibly. In lots of contexts this would whitelist foo.musees.cg70.fr, but not plain musees.cg70.fr without a subdomain (havent double checked what gwtoolset actually does). You probably want to whitelist just musees.cg70.fr

> 
> I followed the way other domain names were whitelisted, assuming it was the
> right way to do it...
> 
> (Reopening for the discussion, please let me know if this is not the right
> venue).

This is the correct venue
Comment 7 Gerrit Notification Bot 2014-04-08 21:54:55 UTC
Change 124754 had a related patch set uploaded by Jean-Frédéric:
Add Musées de la Haute-Saône to wgCopyUploadsDomains

https://gerrit.wikimedia.org/r/124754
Comment 8 Gerrit Notification Bot 2014-04-09 09:17:51 UTC
Change 124754 merged by jenkins-bot:
Add Musées de la Haute-Saône to wgCopyUploadsDomains

https://gerrit.wikimedia.org/r/124754
Comment 9 Antoine "hashar" Musso (WMF) 2014-04-09 09:20:59 UTC
I have deployed Jean-Frédéric change on the cluster, though slightly tweaked it to allow both *.musees.cg70.fr and musees.cg70.fr.

Let me now on IRC (hashar) if there is anything needed.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links