Last modified: 2014-04-15 14:05:09 UTC
badgeItems setting is checked in ChangeOpSiteLink and in SpecialSetSiteLink. It appears this is supposed to be a key (prefixed item id) => value array. I have no idea what the value is supposed to be or if this is even correct understanding of how the setting is supposed to work. The setting needs some comments added in repo/config/Wikibase.defaults.php and in docs/options.wiki so that users can configure it correctly.
Probably "for future use"? And to be able to do quick "key exists" checks in contrast to "search array for value"? I would stick to the associative array. Documentation needed, of course.
This is documented in https://gerrit.wikimedia.org/r/#/c/111609/31/client/config/WikibaseClient.default.php. Needs to get copied into the wiki.
Sorry, this bug is about repo stuff while I was on client. However, this setting also needs documentation.
@bene* does the setting work the same way in the repo?
No, in repo we don't link to icon urls but only store the ids.
Change 123441 had a related patch set uploaded by Bene: Add documentation or badgeItems setting https://gerrit.wikimedia.org/r/123441
Change 123441 abandoned by Bene: Add documentation or badgeItems setting and fix the code accordingly Reason: Per Thiemo I abandon this change and will upload another patch which only adds the documentation. https://gerrit.wikimedia.org/r/123441
Change 125875 had a related patch set uploaded by Bene: Add documentation for badgeItems setting on repo https://gerrit.wikimedia.org/r/125875
Change 125875 merged by jenkins-bot: Add documentation for badgeItems setting on repo https://gerrit.wikimedia.org/r/125875
