Last modified: 2014-07-16 12:27:57 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T65368, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 63368 - review backend part of entity suggester (python code)
review backend part of entity suggester (python code)
Status: VERIFIED FIXED
Product: MediaWiki extensions
Classification: Unclassified
WikidataRepo (Other open bugs)
unspecified
All All
: High major (vote)
: ---
Assigned To: Wikidata bugs
u=dev c=backend p=8 s=2014-05-20
:
Depends on: 66378 66379
Blocks: 46555 64956
  Show dependency tree / graph
 
Reported: 2014-04-01 14:30 UTC by tobias.gritschacher
Modified: 2014-07-16 12:27 UTC (History)
4 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description tobias.gritschacher 2014-04-01 14:30:53 UTC 
https://github.com/Wikidata-lib/PropertySuggester-Python
Comment 1 tobias.gritschacher 2014-04-01 14:36:08 UTC 
Review of the PHP part is bug 63224.
Comment 2 tobias.gritschacher 2014-06-03 14:17:55 UTC 
Review is done from Wikidata-Team side.
Pending WMF review now.
Comment 3 Chris Steipp 2014-06-04 22:54:42 UTC 
Looks fine. The WMF may not be able to run this on the cluster, since we don't make pip available, and I'm not sure if we have ujson available. Might have to have ops install that.

In general, I'd be more happy if this was run on labs, but it shouldn't harm the cluster if we run it there.
Comment 4 Christian Dullweber 2014-06-07 08:05:26 UTC 
Thanks for the review. ujson is optional and only gives a small speedup. the other requirements are only for testing. 
The code could run on labs. The resulting csv file only needs to be accessible to the maintenance script for the import.
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links