Last modified: 2014-11-20 13:39:26 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T65307, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 63307 - Review if existing Ruby code follows Ruby Styleguide
Review if existing Ruby code follows Ruby Styleguide
Status: RESOLVED FIXED
Product: Wikimedia
Classification: Unclassified
Quality Assurance (Other open bugs)
wmf-deployment
All All
: Low normal (vote)
: ---
Assigned To: Željko Filipin
zfilipin
:
Depends on:
Blocks: 60335
  Show dependency tree / graph
 
Reported: 2014-03-31 14:56 UTC by Željko Filipin
Modified: 2014-11-20 13:39 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Željko Filipin 2014-03-31 14:56:08 UTC 
The styleguide:

https://github.com/styleguide/ruby

Repositories with Ruby code:

https://github.com/wikimedia/mediawiki-selenium#links
Comment 1 Željko Filipin 2014-08-09 13:25:31 UTC 
This will be easy to do when bug 69245 is resolved.

New Ruby coding conventions:

https://www.mediawiki.org/wiki/Manual:Coding_conventions/Ruby

Selenium coding conventions:

https://www.mediawiki.org/wiki/Manual:Coding_conventions/Selenium
Comment 2 Gerrit Notification Bot 2014-10-23 13:14:08 UTC 
Change 168277 had a related patch set uploaded by Zfilipin:
Fixed Style/BracesAroundHashParameters RuboCop offense

https://gerrit.wikimedia.org/r/168277
Comment 3 Gerrit Notification Bot 2014-10-23 13:19:39 UTC 
Change 168279 had a related patch set uploaded by Zfilipin:
Fixed RuboCop offense Style/Alias

https://gerrit.wikimedia.org/r/168279
Comment 4 Gerrit Notification Bot 2014-10-23 13:21:34 UTC 
Change 168281 had a related patch set uploaded by Zfilipin:
Fixed RuboCop offense Style/DotPosition

https://gerrit.wikimedia.org/r/168281
Comment 5 Gerrit Notification Bot 2014-10-23 13:36:50 UTC 
Change 168283 had a related patch set uploaded by Zfilipin:
Fixed RuboCop offense Style/LeadingCommentSpace

https://gerrit.wikimedia.org/r/168283
Comment 6 Gerrit Notification Bot 2014-10-23 13:36:54 UTC 
Change 168284 had a related patch set uploaded by Zfilipin:
Fixed RuboCop offense Style/PercentLiteralDelimiters

https://gerrit.wikimedia.org/r/168284
Comment 7 Gerrit Notification Bot 2014-10-23 13:36:58 UTC 
Change 168285 had a related patch set uploaded by Zfilipin:
Fixed RuboCop offense Style/SignalException

https://gerrit.wikimedia.org/r/168285
Comment 8 Gerrit Notification Bot 2014-10-23 13:37:02 UTC 
Change 168286 had a related patch set uploaded by Zfilipin:
Fixed RuboCop offense Style/SpaceInsideParens

https://gerrit.wikimedia.org/r/168286
Comment 9 Gerrit Notification Bot 2014-10-23 13:37:07 UTC 
Change 168287 had a related patch set uploaded by Zfilipin:
Fixed RuboCop offense Style/SpecialGlobalVars

https://gerrit.wikimedia.org/r/168287
Comment 10 Gerrit Notification Bot 2014-10-23 13:37:15 UTC 
Change 168288 had a related patch set uploaded by Zfilipin:
Fixed RuboCop offense Style/StringLiterals

https://gerrit.wikimedia.org/r/168288
Comment 11 Gerrit Notification Bot 2014-10-23 13:37:19 UTC 
Change 168289 had a related patch set uploaded by Zfilipin:
Fixed RuboCop offense Style/UnneededPercentQ

https://gerrit.wikimedia.org/r/168289
Comment 12 Gerrit Notification Bot 2014-10-23 13:37:23 UTC 
Change 168290 had a related patch set uploaded by Zfilipin:
Fixed RuboCop offense Style/WordArray

https://gerrit.wikimedia.org/r/168290
Comment 13 Gerrit Notification Bot 2014-10-23 13:55:36 UTC 
Change 168292 had a related patch set uploaded by Zfilipin:
Fixed RuboCop offense Lint/UselessAssignment

https://gerrit.wikimedia.org/r/168292
Comment 14 Gerrit Notification Bot 2014-10-23 15:58:58 UTC 
Change 168309 had a related patch set uploaded by Zfilipin:
Fixed RuboCop offense Style/ClassAndModuleChildren

https://gerrit.wikimedia.org/r/168309
Comment 15 Gerrit Notification Bot 2014-10-23 15:59:04 UTC 
Change 168310 had a related patch set uploaded by Zfilipin:
WIP Fixed RuboCop offense Metrics/LineLength

https://gerrit.wikimedia.org/r/168310
Comment 16 Gerrit Notification Bot 2014-10-23 16:32:53 UTC 
Change 168314 had a related patch set uploaded by Zfilipin:
Fixed RuboCop offense Lint/UnusedBlockArgument

https://gerrit.wikimedia.org/r/168314
Comment 17 Gerrit Notification Bot 2014-10-23 16:35:36 UTC 
Change 168316 had a related patch set uploaded by Zfilipin:
Fixed RuboCop offense Lint/UnusedMethodArgument

https://gerrit.wikimedia.org/r/168316
Comment 18 Gerrit Notification Bot 2014-10-23 16:38:41 UTC 
Change 168318 had a related patch set uploaded by Zfilipin:
Fixed RuboCop offense Lint/UselessAccessModifier

https://gerrit.wikimedia.org/r/168318
Comment 19 Gerrit Notification Bot 2014-10-23 16:41:18 UTC 
Change 168320 had a related patch set uploaded by Zfilipin:
Fixed RuboCop offense Style/AndOr

https://gerrit.wikimedia.org/r/168320
Comment 20 Gerrit Notification Bot 2014-10-23 17:31:22 UTC 
Change 168277 merged by jenkins-bot:
Fixed RuboCop offense Style/BracesAroundHashParameters

https://gerrit.wikimedia.org/r/168277
Comment 21 Gerrit Notification Bot 2014-10-28 13:49:05 UTC 
Change 169363 had a related patch set uploaded by Zfilipin:
Fixed Lint/UnusedBlockArgument RuboCop offense

https://gerrit.wikimedia.org/r/169363
Comment 22 Gerrit Notification Bot 2014-10-28 22:14:51 UTC 
Change 168279 merged by Dduvall:
Use alias_method when aliasing macro-defined attributes

https://gerrit.wikimedia.org/r/168279
Comment 23 Gerrit Notification Bot 2014-10-28 22:21:13 UTC 
Change 168281 merged by jenkins-bot:
Added custom RuboCop check for Style/DotPosition

https://gerrit.wikimedia.org/r/168281
Comment 24 Gerrit Notification Bot 2014-10-28 22:24:31 UTC 
Change 168283 merged by jenkins-bot:
Fixed RuboCop offense Style/LeadingCommentSpace

https://gerrit.wikimedia.org/r/168283
Comment 25 Gerrit Notification Bot 2014-10-28 22:28:25 UTC 
Change 168284 merged by jenkins-bot:
Fixed RuboCop offense Style/PercentLiteralDelimiters

https://gerrit.wikimedia.org/r/168284
Comment 26 Gerrit Notification Bot 2014-10-29 00:23:46 UTC 
Change 168286 merged by jenkins-bot:
Fixed RuboCop offense Style/SpaceInsideParens

https://gerrit.wikimedia.org/r/168286
Comment 27 Gerrit Notification Bot 2014-10-29 17:56:51 UTC 
Change 168287 merged by jenkins-bot:
Fixed RuboCop offense Style/SpecialGlobalVars

https://gerrit.wikimedia.org/r/168287
Comment 28 Gerrit Notification Bot 2014-10-29 19:06:19 UTC 
Change 168288 merged by jenkins-bot:
Fixed RuboCop offense Style/StringLiterals

https://gerrit.wikimedia.org/r/168288
Comment 29 Gerrit Notification Bot 2014-10-29 19:27:38 UTC 
Change 168289 merged by jenkins-bot:
Fixed RuboCop offense Style/UnneededPercentQ

https://gerrit.wikimedia.org/r/168289
Comment 30 Gerrit Notification Bot 2014-10-29 19:56:41 UTC 
Change 168290 merged by Dduvall:
Fixed RuboCop offense Style/WordArray

https://gerrit.wikimedia.org/r/168290
Comment 31 Gerrit Notification Bot 2014-10-29 20:03:57 UTC 
Change 168292 merged by jenkins-bot:
Fixed RuboCop offense Lint/UselessAssignment

https://gerrit.wikimedia.org/r/168292
Comment 32 Gerrit Notification Bot 2014-10-29 21:03:16 UTC 
Change 168309 merged by Dduvall:
Fixed RuboCop offense Style/ClassAndModuleChildren

https://gerrit.wikimedia.org/r/168309
Comment 33 Gerrit Notification Bot 2014-10-30 21:21:29 UTC 
Change 168285 merged by jenkins-bot:
Ignore RuboCop offense Style/SignalException

https://gerrit.wikimedia.org/r/168285
Comment 34 Gerrit Notification Bot 2014-10-30 21:24:40 UTC 
Change 168310 merged by jenkins-bot:
Fixed RuboCop offense Metrics/LineLength

https://gerrit.wikimedia.org/r/168310
Comment 35 Gerrit Notification Bot 2014-10-30 22:25:50 UTC 
Change 170189 had a related patch set uploaded by Dduvall:
Ignoring RuboCop rule Style/Alias

https://gerrit.wikimedia.org/r/170189
Comment 36 Gerrit Notification Bot 2014-11-04 10:34:49 UTC 
Change 168320 abandoned by Zfilipin:
Fixed RuboCop offense Style/AndOr

Reason:
Another big refactoring is happening at the same time: https://gerrit.wikimedia.org/r/#/q/branch:env-abstraction-layer,n,z

https://gerrit.wikimedia.org/r/168320
Comment 37 Gerrit Notification Bot 2014-11-04 10:35:06 UTC 
Change 168318 abandoned by Zfilipin:
Fixed RuboCop offense Lint/UselessAccessModifier

Reason:
Another big refactoring is happening at the same time: https://gerrit.wikimedia.org/r/#/q/branch:env-abstraction-layer,n,z

https://gerrit.wikimedia.org/r/168318
Comment 38 Gerrit Notification Bot 2014-11-04 10:35:13 UTC 
Change 168316 abandoned by Zfilipin:
Fixed RuboCop offense Lint/UnusedMethodArgument

Reason:
Another big refactoring is happening at the same time: https://gerrit.wikimedia.org/r/#/q/branch:env-abstraction-layer,n,z

https://gerrit.wikimedia.org/r/168316
Comment 39 Gerrit Notification Bot 2014-11-04 10:35:16 UTC 
Change 168314 abandoned by Zfilipin:
Fixed RuboCop offense Lint/UnusedBlockArgument

Reason:
Another big refactoring is happening at the same time: https://gerrit.wikimedia.org/r/#/q/branch:env-abstraction-layer,n,z

https://gerrit.wikimedia.org/r/168314
Comment 40 Gerrit Notification Bot 2014-11-04 13:01:34 UTC 
Change 170911 had a related patch set uploaded by Zfilipin:
Fixed Style/SpaceAfterComma RuboCop offense

https://gerrit.wikimedia.org/r/170911
Comment 41 Gerrit Notification Bot 2014-11-04 17:17:35 UTC 
Change 170911 merged by jenkins-bot:
Fixed Style/SpaceAfterComma RuboCop offense

https://gerrit.wikimedia.org/r/170911
Comment 42 Gerrit Notification Bot 2014-11-06 22:20:24 UTC 
Change 171742 had a related patch set uploaded by Zfilipin:
QA: Update RuboCop configuration file for new RuboCop version

https://gerrit.wikimedia.org/r/171742
Comment 43 Gerrit Notification Bot 2014-11-06 22:20:28 UTC 
Change 171743 had a related patch set uploaded by Zfilipin:
QA: Fixed Lint/EndAlignment RuboCop offense

https://gerrit.wikimedia.org/r/171743
Comment 44 Gerrit Notification Bot 2014-11-06 22:20:32 UTC 
Change 171744 had a related patch set uploaded by Zfilipin:
QA: Fixed Lint/ParenthesesAsGroupedExpression RuboCop offense

https://gerrit.wikimedia.org/r/171744
Comment 45 Gerrit Notification Bot 2014-11-06 22:20:37 UTC 
Change 171745 had a related patch set uploaded by Zfilipin:
QA: Fixed Lint/UnusedBlockArgument RuboCop offense

https://gerrit.wikimedia.org/r/171745
Comment 46 Gerrit Notification Bot 2014-11-06 22:20:41 UTC 
Change 171746 had a related patch set uploaded by Zfilipin:
QA: Ignoring Metrics/ClassLength RuboCop cop

https://gerrit.wikimedia.org/r/171746
Comment 47 Gerrit Notification Bot 2014-11-06 22:20:46 UTC 
Change 171747 had a related patch set uploaded by Zfilipin:
QA: Fixed Style/BracesAroundHashParameters RoboCop offense

https://gerrit.wikimedia.org/r/171747
Comment 48 Gerrit Notification Bot 2014-11-06 22:20:50 UTC 
Change 171748 had a related patch set uploaded by Zfilipin:
QA: Fixed Style/CommentAnnotation RuboCop offense

https://gerrit.wikimedia.org/r/171748
Comment 49 Gerrit Notification Bot 2014-11-06 22:20:55 UTC 
Change 171749 had a related patch set uploaded by Zfilipin:
QA: Fixed Style/EmptyLines RuboCop offense

https://gerrit.wikimedia.org/r/171749
Comment 50 Gerrit Notification Bot 2014-11-06 22:20:59 UTC 
Change 171750 had a related patch set uploaded by Zfilipin:
QA: Fixed Style/EmptyLinesAroundClassBody RuboCop offense

https://gerrit.wikimedia.org/r/171750
Comment 51 Gerrit Notification Bot 2014-11-06 22:21:03 UTC 
Change 171751 had a related patch set uploaded by Zfilipin:
QA: Fixed Style/HashSyntax RuboCop offense

https://gerrit.wikimedia.org/r/171751
Comment 52 Gerrit Notification Bot 2014-11-06 22:29:54 UTC 
Change 171751 abandoned by Zfilipin:
QA: Fixed Style/HashSyntax RuboCop offense

https://gerrit.wikimedia.org/r/171751
Comment 53 Gerrit Notification Bot 2014-11-06 22:29:57 UTC 
Change 171750 abandoned by Zfilipin:
QA: Fixed Style/EmptyLinesAroundClassBody RuboCop offense

https://gerrit.wikimedia.org/r/171750
Comment 54 Gerrit Notification Bot 2014-11-06 22:30:00 UTC 
Change 171749 abandoned by Zfilipin:
QA: Fixed Style/EmptyLines RuboCop offense

https://gerrit.wikimedia.org/r/171749
Comment 55 Gerrit Notification Bot 2014-11-06 22:30:05 UTC 
Change 171748 abandoned by Zfilipin:
QA: Fixed Style/CommentAnnotation RuboCop offense

https://gerrit.wikimedia.org/r/171748
Comment 56 Gerrit Notification Bot 2014-11-06 22:30:07 UTC 
Change 171747 abandoned by Zfilipin:
QA: Fixed Style/BracesAroundHashParameters RoboCop offense

https://gerrit.wikimedia.org/r/171747
Comment 57 Gerrit Notification Bot 2014-11-06 22:30:11 UTC 
Change 171746 abandoned by Zfilipin:
QA: Ignoring Metrics/ClassLength RuboCop cop

https://gerrit.wikimedia.org/r/171746
Comment 58 Gerrit Notification Bot 2014-11-06 22:30:15 UTC 
Change 171745 abandoned by Zfilipin:
QA: Fixed Lint/UnusedBlockArgument RuboCop offense

https://gerrit.wikimedia.org/r/171745
Comment 59 Gerrit Notification Bot 2014-11-06 22:30:20 UTC 
Change 171744 abandoned by Zfilipin:
QA: Fixed Lint/ParenthesesAsGroupedExpression RuboCop offense

https://gerrit.wikimedia.org/r/171744
Comment 60 Gerrit Notification Bot 2014-11-06 22:30:24 UTC 
Change 171743 abandoned by Zfilipin:
QA: Fixed Lint/EndAlignment RuboCop offense

https://gerrit.wikimedia.org/r/171743
Comment 61 Gerrit Notification Bot 2014-11-06 22:30:31 UTC 
Change 171742 abandoned by Zfilipin:
QA: Update RuboCop configuration file for new RuboCop version

https://gerrit.wikimedia.org/r/171742
Comment 62 Gerrit Notification Bot 2014-11-07 04:45:35 UTC 
Change 171802 had a related patch set uploaded by Lubaochuan:
Removed Style/LeadingCommentSpace RuboCop offense from .rubocop_todo.yml file

https://gerrit.wikimedia.org/r/171802
Comment 63 Gerrit Notification Bot 2014-11-10 16:22:21 UTC 
Change 172245 had a related patch set uploaded by Vikassy:
[BrowserTest] Fixed Style/CommentAnnotation RuboCop offense

https://gerrit.wikimedia.org/r/172245
Comment 64 Gerrit Notification Bot 2014-11-10 17:16:04 UTC 
Change 171802 abandoned by Lubaochuan:
Removed Style/LeadingCommentSpace RuboCop offense from .rubocop_todo.yml file

Reason:
Will incorporating this change by amending the previous/original change at https://gerrit.wikimedia.org/r/#/c/171508/

https://gerrit.wikimedia.org/r/171802
Comment 65 Gerrit Notification Bot 2014-11-11 12:54:18 UTC 
Change 172535 had a related patch set uploaded by Lubaochuan:
Fixed Style/Documentation RuboCop offense

https://gerrit.wikimedia.org/r/172535
Comment 66 Gerrit Notification Bot 2014-11-11 13:44:05 UTC 
Change 169363 merged by jenkins-bot:
Fixed Lint/UnusedBlockArgument RuboCop offense

https://gerrit.wikimedia.org/r/169363
Comment 67 Gerrit Notification Bot 2014-11-11 14:02:29 UTC 
Change 172535 merged by jenkins-bot:
Fixed Style/Documentation RuboCop offense

https://gerrit.wikimedia.org/r/172535
Comment 68 Gerrit Notification Bot 2014-11-12 13:16:05 UTC 
Change 172708 had a related patch set uploaded by Zfilipin:
tests: RuboCop checks .docs/CustomTags.rb

https://gerrit.wikimedia.org/r/172708
Comment 69 Gerrit Notification Bot 2014-11-12 15:50:19 UTC 
Change 172708 merged by jenkins-bot:
tests: RuboCop checks .docs/CustomTags.rb

https://gerrit.wikimedia.org/r/172708
Comment 70 Gerrit Notification Bot 2014-11-14 02:45:34 UTC 
Change 171508 had a related patch set uploaded by Lubaochuan:
Fixed Style/LeadingCommentSpace RuboCop offense Removed Style/LeadingCommentSpace RuboCop offense from .rubocop_todo.yml file

https://gerrit.wikimedia.org/r/171508
Comment 71 Gerrit Notification Bot 2014-11-14 10:10:00 UTC 
Change 171508 had a related patch set uploaded by Lubaochuan:
Fixed Style/LeadingCommentSpace RuboCop offense

https://gerrit.wikimedia.org/r/171508
Comment 72 Gerrit Notification Bot 2014-11-17 13:39:24 UTC 
Change 171508 merged by jenkins-bot:
Fixed Style/LeadingCommentSpace RuboCop offense

https://gerrit.wikimedia.org/r/171508
Comment 73 Željko Filipin 2014-11-20 13:39:26 UTC 
The review is mostly done. "All" that is left is fixing the problems.
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links