Last modified: 2014-03-31 08:19:46 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T65293, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 63293 - JSON linter does not catch syntax errors
JSON linter does not catch syntax errors
Status: RESOLVED DUPLICATE of bug 58279
Product: Wikimedia
Classification: Unclassified
Continuous integration (Other open bugs)
wmf-deployment
All All
: Unprioritized major (vote)
: ---
Assigned To: Nobody - You can work on this!
https://gerrit.wikimedia.org/r/#/c/12...
:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2014-03-31 08:11 UTC by Siebrand Mazeland
Modified: 2014-03-31 08:19 UTC (History)
7 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Siebrand Mazeland 2014-03-31 08:11:58 UTC 
In Gerrit change #122270, a line in JSON contained the following:

"key" => "value",

The Jenkins jobs for the Scribunto extension, and in particular the job jslint I believe, didn't disapprove of this, even though it is invalid JSON.

https://integration.wikimedia.org/ci/job/mwext-Scribunto-jslint/598/console is the job output.

Expected behaviour: JSON linter should catch JSON syntax errors and jobs running this linter should fail in such cases.

I set the severity for this issue to major.
Comment 1 Nemo 2014-03-31 08:15:08 UTC 
For comparison:

$ json_verify < i18n/qqq.json
lexical error: invalid char in json text.
                                        {     "@metadata": {         "
                     (right here) ------^
JSON is invalid
Comment 2 Antoine "hashar" Musso (WMF) 2014-03-31 08:19:46 UTC 
Json files are not validated yet. Need to add to the jslint jobs the json_decode() wrapper I wrote which is bug 58279.  I forgot to deploy it last week.

*** This bug has been marked as a duplicate of bug 58279 ***
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links