Last modified: 2014-04-15 13:57:45 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T65087, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 63087 - SpecialWatchlistQueryHandler::addWikibaseConditions() fatal errors and exceptions
SpecialWatchlistQueryHandler::addWikibaseConditions() fatal errors and except...
Status: VERIFIED FIXED
Product: MediaWiki extensions
Classification: Unclassified
WikidataClient (Other open bugs)
unspecified
All All
: Highest blocker with 2 votes (vote)
: ---
Assigned To: Wikidata bugs
:
: 63089 (view as bug list)
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-03-25 20:21 UTC by Bryan Davis
Modified: 2014-04-15 13:57 UTC (History)
7 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Bryan Davis 2014-03-25 20:21:17 UTC
Found in logstash after irc user Raymond_ reported seeing a fatal error on his Commons watchlist page:

2014-03-25T20:06:45.000Z Invalid option hideWikibase
#0 /usr/local/apache/common-local/php-1.23wmf19/includes/FormOptions.php(176): FormOptions->validateName('hideWikibase', true)
#1 /usr/local/apache/common-local/php-1.23wmf19/extensions/Wikidata/extensions/Wikibase/client/includes/hooks/SpecialWatchlistQueryHandler.php(49): FormOptions->getValue('hideWikibase')
#2 /usr/local/apache/common-local/php-1.23wmf19/extensions/Wikidata/extensions/Wikibase/client/WikibaseClient.hooks.php(318): Wikibase\Client\Hooks\SpecialWatchlistQueryHandler->addWikibaseConditions(Object(WebRequest), Array, Object(FormOptions))
#3 [internal function]: Wikibase\ClientHooks::onSpecialWatchlistQuery(Array, Array, Array, Array, Object(FormOptions))


2014-03-25T20:00:07.000Z PHP Fatal error:  Call to a member function getValue() on a non-object in /usr/local/apache/common-local/php-1.23wmf19/extensions/Wikidata/extensions/Wikibase/client/includes/hooks/SpecialWatchlistQueryHandler.php on line 49
Comment 1 Raimond Spekking 2014-03-25 20:29:32 UTC
Wikimedia Commons watchlist is unreachable due to this error -> BLOCKER
Comment 2 rlp 2014-03-25 20:39:07 UTC
As reported on Commons, this is definitely affecting multiple users. See 
https://commons.wikimedia.org/wiki/Commons:Village_pump#Fatal_exception_of_type_MWException_when_trying_to_view_Special:Watchlist
Comment 3 Sam Reed (reedy) 2014-03-25 21:27:56 UTC
*** Bug 63089 has been marked as a duplicate of this bug. ***
Comment 4 Gerrit Notification Bot 2014-03-25 21:32:28 UTC
Change 120941 had a related patch set uploaded by Hoo man:
Prevent FormOptions from throwing an exception with the enhanced changes list

https://gerrit.wikimedia.org/r/120941
Comment 5 Gerrit Notification Bot 2014-03-25 21:40:36 UTC
Change 120941 merged by jenkins-bot:
Prevent FormOptions from throwing an exception with the enhanced changes list

https://gerrit.wikimedia.org/r/120941
Comment 6 Gerrit Notification Bot 2014-03-25 21:41:08 UTC
Change 120946 had a related patch set uploaded by Hoo man:
Prevent FormOptions from throwing an exception with the enhanced changes list

https://gerrit.wikimedia.org/r/120946
Comment 7 Gerrit Notification Bot 2014-03-25 21:47:22 UTC
Change 120946 merged by jenkins-bot:
Prevent FormOptions from throwing an exception with the enhanced changes list

https://gerrit.wikimedia.org/r/120946
Comment 8 Marius Hoch 2014-03-25 22:01:05 UTC
I'll deploy the fix within the next couple of minutes.
Comment 9 Bryan Davis 2014-03-27 18:29:26 UTC
Looks like this isn't quite fixed yet:

2014-03-27T18:27:57.000Z PHP Fatal error:  Call to a member function getValue() on a non-object in /usr/local/apache/common-local/php-1.23wmf19/extensions/Wikidata/extensions/Wikibase/client/includes/hooks/SpecialWatchlistQueryHandler.php on line 51

This error message is trending now that *.wikipedia switched to 1.23wmf19
Comment 10 Bryan Davis 2014-03-27 18:37:45 UTC
2014-03-27 09:30:05] Fatal error: Call to a member function getValue() on a non
-object at /usr/local/apache/common-local/php-1.23wmf19/extensions/Wikidata/exte
nsions/Wikibase/client/includes/hooks/SpecialWatchlistQueryHandler.php on line 5
1
Server: mw1056
Method: GET
URL: http://en.wikisource.org/w/index.php?title=Special:Watchlist&watchlistview=
feed&filter=all
Backtrace:
#0 /usr/local/apache/common-local/php-1.23wmf19/extensions/Wikidata/extensions/Wikibase/client/includes/hooks/SpecialWatchlistQueryHandler.php(51): Wikibase\Client\Hooks\SpecialWatchlistQueryHandler::addWikibaseConditions()
#1 /usr/local/apache/common-local/php-1.23wmf19/extensions/Wikidata/extensions/Wikibase/client/WikibaseClient.hooks.php(318): Wikibase\Client\Hooks\SpecialWatchlistQueryHandler->addWikibaseConditions(Object(WebRequest), Array, Array)
#2 [internal function]: Wikibase\ClientHooks::onSpecialWatchlistQuery(Array, Array, Array, Array, Array)
#3 /usr/local/apache/common-local/php-1.23wmf19/includes/Hooks.php(206): call_user_func_array('\Wikibase\Clien...', Array)
#4 /usr/local/apache/common-local/php-1.23wmf19/includes/GlobalFunctions.php(4011): Hooks::run('SpecialWatchlis...', Array, NULL)
#5 /usr/local/apache/common-local/php-1.23wmf19/extensions/MobileFrontend/includes/specials/SpecialMobileWatchlist.php(268): wfRunHooks('SpecialWatchlis...', Array)
#6 /usr/local/apache/common-local/php-1.23wmf19/extensions/MobileFrontend/includes/specials/SpecialMobileWatchlist.php(68): SpecialMobileWatchlist->doFeedQuery()
#7 /usr/local/apache/common-local/php-1.23wmf19/extensions/MobileFrontend/includes/specials/MobileSpecialPage.php(39): SpecialMobileWatchlist->executeWhenAvailable(NULL)
#8 /usr/local/apache/common-local/php-1.23wmf19/extensions/MobileFrontend/includes/specials/MobileSpecialPageFeed.php(13): MobileSpecialPage->execute(NULL)
#9 /usr/local/apache/common-local/php-1.23wmf19/includes/specialpage/SpecialPage.php(376): MobileSpecialPageFeed->execute(NULL)
#10 /usr/local/apache/common-local/php-1.23wmf19/includes/specialpage/SpecialPageFactory.php(490): SpecialPage->run(NULL)
#11 /usr/local/apache/common-local/php-1.23wmf19/includes/Wiki.php(285): SpecialPageFactory::executePath(Object(Title), Object(RequestContext))
#12 /usr/local/apache/common-local/php-1.23wmf19/includes/Wiki.php(588): MediaWiki->performRequest()
#13 /usr/local/apache/common-local/php-1.23wmf19/includes/Wiki.php(447): MediaWiki->main()
#14 /usr/local/apache/common-local/php-1.23wmf19/index.php(49): MediaWiki->run()
#15 /usr/local/apache/common-local/w/index.php(3): require('/usr/local/apac...')
#16 {main}
Comment 11 Gerrit Notification Bot 2014-03-27 19:10:01 UTC
Change 121432 had a related patch set uploaded by Hoo man:
Support null as last parameter for the SpecialWatchlistQuery hook

https://gerrit.wikimedia.org/r/121432
Comment 12 Gerrit Notification Bot 2014-03-27 19:15:00 UTC
Change 121432 merged by Addshore:
Support null as last parameter for the SpecialWatchlistQuery hook

https://gerrit.wikimedia.org/r/121432
Comment 13 Gerrit Notification Bot 2014-03-27 19:18:13 UTC
Change 121434 had a related patch set uploaded by Hoo man:
Support null as last parameter for the SpecialWatchlistQuery hook

https://gerrit.wikimedia.org/r/121434
Comment 14 Gerrit Notification Bot 2014-03-27 19:18:51 UTC
Change 121434 merged by Addshore:
Support null as last parameter for the SpecialWatchlistQuery hook

https://gerrit.wikimedia.org/r/121434
Comment 15 Marius Hoch 2014-03-27 19:50:42 UTC
The issue we have today is another one... already fixed, but pending deploy (will take 20 minutes, I presume)

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links