Last modified: 2014-05-31 01:07:03 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T64852, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 62852 - VisualEditor: [Regression wmf18] Making an image Right, Basic and Border does not include the Right and Border in the wikitext
VisualEditor: [Regression wmf18] Making an image Right, Basic and Border does...
Status: RESOLVED FIXED
Product: VisualEditor
Classification: Unclassified
Editing Tools (Other open bugs)
unspecified
All All
: Normal normal
: VE-deploy-2014-05-29
Assigned To: Moriel Schottlender
:
Depends on:
Blocks: 65829
  Show dependency treegraph
 
Reported: 2014-03-19 22:04 UTC by Rummana Yasmeen
Modified: 2014-05-31 01:07 UTC (History)
5 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
Screenshot (9.97 KB, image/png)
2014-03-19 22:06 UTC, Rummana Yasmeen
Details

Description Rummana Yasmeen 2014-03-19 22:04:15 UTC
Steps to reproduce:

1.Open a page with VE
2.Now change the image settings to Right,Basic and Border 
3.Save the page

Observed Result:
In the wikitext the options "Right" and "Border" are missing

Test Environment: http://en.wikipedia.beta.wmflabs.org/
: Chrome Version 26.0.1410.65 & FF 25
OS: MAC OS X 10. 8. 5
Comment 1 Rummana Yasmeen 2014-03-19 22:06:07 UTC
Created attachment 14864 [details]
Screenshot
Comment 2 James Forrester 2014-03-19 22:09:19 UTC
Parsoid does the right thing with the input giving the expected output:

<figure class="mw-default-size mw-halign-right mw-image-border" typeof="mw:Image" data-parsoid="{&quot;optList&quot;:[{&quot;ck&quot;:&quot;thumbnail&quot;,&quot;ak&quot;:&quot;thumb&quot;},{&quot;ck&quot;:&quot;left&quot;,&quot;ak&quot;:&quot;left&quot;},{&quot;ck&quot;:&quot;caption&quot;,&quot;ak&quot;:&quot;Foo&quot;}],&quot;dsr&quot;:[0,35,2,2]}"><a href="./File:Example.png" data-parsoid="{&quot;a&quot;:{&quot;href&quot;:&quot;./File:Example.png&quot;},&quot;dsr&quot;:[2,null,null,null]}"><img resource="./File:Example.png" src="//upload.wikimedia.org/wikipedia/en/thumb/7/70/Example.png/220px-Example.png" height="238" width="220" data-parsoid="{&quot;a&quot;:{&quot;resource&quot;:&quot;./File:Example.png&quot;,&quot;height&quot;:&quot;238&quot;,&quot;width&quot;:&quot;220&quot;},&quot;sa&quot;:{&quot;resource&quot;:&quot;File:Example.png&quot;}}"></a><figcaption data-parsoid="{&quot;dsr&quot;:[null,33,null,null]}">Foo</figcaption></figure>

->

[[File:Example.png|Foo|right|border]]
Comment 3 Moriel Schottlender 2014-03-20 18:20:48 UTC
CE responds correctly to the type and alignment shifts, and yet something seems to goes awry in the DM. I'm checking into the issue.
Comment 4 Rummana Yasmeen 2014-05-20 23:46:55 UTC
So, this is still happening.In addition to that, for all Right aligned Images regardless of its type the alignment options gets missing from the wikitext
Comment 5 James Forrester 2014-05-21 00:04:49 UTC
Skipping right (and just using default) is OK for thumb and frame (but not frameless or basic).
Comment 6 Rummana Yasmeen 2014-05-28 21:14:07 UTC
Verified the fix in Betalabs
Comment 7 Rummana Yasmeen 2014-05-31 01:07:03 UTC
Verified the fix in test2

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links