Last modified: 2014-06-12 04:56:00 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T64818, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 62818 - VisualEditor: Link inspector doesn't save changes when closing while XHR is pending
VisualEditor: Link inspector doesn't save changes when closing while XHR is p...
Status: RESOLVED FIXED
Product: VisualEditor
Classification: Unclassified
Editing Tools (Other open bugs)
unspecified
All All
: High normal
: VE-deploy-2014-06-12
Assigned To: Trevor Parscal
:
Depends on:
Blocks: ve-linkediting
  Show dependency treegraph
 
Reported: 2014-03-19 02:23 UTC by Roan Kattouw
Modified: 2014-06-12 04:56 UTC (History)
5 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Roan Kattouw 2014-03-19 02:23:35 UTC
Introduce artificial delays in your API modules (sleep(2); at the top of ApiOpenSearch::execute() and ApiQueryInfo::execute(); alternatively, you can try this in production if you're quick enough), then perform the following steps quickly:

1. Inspect an existing link
2. Change its target
3. Before the API request completes, close the link inspector by clicking out or clicking the back arrow
4. Inspect the link again

Expected: new target shows in inspector
Actual: old target shows

With the keyboard it's even weirder:

1. Inspect an existing link
2. Type "foo". Wait for the API request to come back and display suggestions
3. Type "bar" at the end (so you now have "foobar"), then quickly (before the API call comes back) press Enter.
4. Expected: inspector closes. Actual: input value is reset to "foo"
(At least if you press Enter again, "foo" is actually saved.)

You can work around this and still reproduce the first bug:

1. Inspect an existing link
2. Type "foo"
3. If a suggestion box is displayed (perhaps because "f" was in cache, or because the previous value was in cache), press Esc to dismiss it
4. Press Enter, the inspector closes
5. Inspect the link again

Expected: "foo"
Actual: previous value
Comment 1 James Forrester 2014-06-12 04:56:00 UTC
This looks like it's now been fixed. I think.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links