Last modified: 2014-09-08 10:56:45 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T64691, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 62691 - Flow: Parsoid ref handling broken by <base href> tag
Flow: Parsoid ref handling broken by <base href> tag
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
Flow (Other open bugs)
master
All All
: Normal normal (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-03-15 08:19 UTC by spage
Modified: 2014-09-08 10:56 UTC (History)
5 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description spage 2014-03-15 08:19:06 UTC
In a Flow post, add the wikitext:

Test<ref>Reference</ref>
<references>

Parsoid generates a reference counter and a references section with <a href="#cite_note-1"> links between them. Wahoo!

But Flow's includes/View.php outputs a
  <base href="/wiki/Talk:Name_of_Flow_board">
tag. That turns the local href into a full URL to the Flow board. So if you view a single topic at its Permalink, then clicking the [1] or ↑  forces a page reload (unfortunate) and if the post is old and not part of the first 10 topics on the board, the fragment won't be on the page at all (bad).

The comment in View.php before outputting a base href tag is "Temporary hack to make relative links work when the page is requested as /w/index.php?title=". But nowadays links to pages and to images are no longer relative links, they are absolute paths like href="/wiki/Main_Page" and src="//ee-flow.wmflabs.org/w/images/7/77/Cucurbita_moschata_Butternut_2012_G2.jpg".  So maybe the base href is no longer required?
Comment 1 Matthias Mullie 2014-09-08 10:56:45 UTC
Looks like this one's fixed: http://ee-flow.wmflabs.org/wiki/Topic:S1rv2yrsl9ptd7y8#cite_note-1

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links