Last modified: 2014-04-22 08:10:31 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T64556, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 62556 - Flow: Reply • Edit buttons don't highlight or click
Flow: Reply • Edit buttons don't highlight or click
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
Flow (Other open bugs)
master
All All
: Normal normal (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2014-03-12 00:33 UTC by spage
Modified: 2014-04-22 08:10 UTC (History)
6 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description spage 2014-03-12 00:33:28 UTC 
The Reply • Edit (and • Thanks) "buttons" for a post don't do anything when you hover and click on them. They should work like the Cancel button.

The fix is to style them mw-ui-button mw-ui-quiet , and then subtract the margins and bolding of mw-ui-quiet.  May Galloway calls these "light" buttons, maybe that style should be part of Agora in core. For now either customize .flow-post-interaction .mw-ui-button.mw-ui-quiet , or define a new style {flow/mw}-ui-light.

Also related to bug 62297 (Gerrit change #113066). When these bugs are fixed the .flow-post-interaction-separator CSS can be updated and simplified.
Comment 1 spage 2014-03-17 19:00:24 UTC 
I think Reply & Edit should also be mw-ui-progressive (blue on hover/click) and Thank should be mw-ui-constructive (green on hover/click).

Tracked in https://trello.com/c/wBiXSreC
Moving this "light" or "inline" style to core mediawiki.ui is bug 62744.
Comment 2 Gerrit Notification Bot 2014-03-20 20:02:23 UTC 
Change 119812 had a related patch set uploaded by Bencmq:
Apply hover/click highlight to post interaction links

https://gerrit.wikimedia.org/r/119812
Comment 3 Gerrit Notification Bot 2014-03-20 20:05:05 UTC 
Change 119814 had a related patch set uploaded by Bencmq:
Add hover highlight to Thank link in Flow posts

https://gerrit.wikimedia.org/r/119814
Comment 4 Gerrit Notification Bot 2014-04-01 20:57:49 UTC 
Change 119814 merged by jenkins-bot:
Add hover highlight to Thank link in Flow posts

https://gerrit.wikimedia.org/r/119814
Comment 5 Gerrit Notification Bot 2014-04-01 20:59:41 UTC 
Change 119812 merged by jenkins-bot:
Reorganise flow-post-interaction link styling

https://gerrit.wikimedia.org/r/119812
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links