Last modified: 2014-05-17 00:12:48 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T64543, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 62543 - Code hygiene: Having a KeepGoingOverlay and KeepGoingDrawer is confusing
Code hygiene: Having a KeepGoingOverlay and KeepGoingDrawer is confusing
Status: RESOLVED FIXED
Product: MobileFrontend
Classification: Unclassified
beta (Other open bugs)
unspecified
All All
: Unprioritized normal
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks: code_quality
  Show dependency tree / graph
 
Reported: 2014-03-11 18:10 UTC by Jon
Modified: 2014-05-17 00:12 UTC (History)
6 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Jon 2014-03-11 18:10:05 UTC 
Both look identical making development on this feature hard. Let's get this JavaScript code consolidated.
Comment 1 Ryan Kaldari 2014-03-11 18:14:38 UTC 
Fixing this bug means deciding what we want to do with the random campaign feature. If we're keeping it, we consolidate the code. If we're not keeping it, we ditch the KeepGoingDrawer and let the KeepGoingOverlay remain relatively simple.
Comment 2 Bingle 2014-03-11 18:15:12 UTC 
Prioritization and scheduling of this bug is tracked on Mingle card https://wikimedia.mingle.thoughtworks.com/projects/mobile/cards/1762
Comment 3 Jon 2014-03-11 21:19:13 UTC 
The random feature came out of the fact the KeepGoingDrawer was a generic reusable component, it seems KeepGoingOverlay is less generic now so that's why it isn't using it.

I think regardless of whether we keep the random feature this would be a good exercise for future developments using the keep going overlay (also I think the KeepGoingOverlay name is a bit misleading - KeepGoingOverlayDrawer sounds more descriptive).
Comment 4 Max Semenik 2014-05-17 00:12:48 UTC 
KeepGoingDrawer doesn't exist anymore.
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links