Last modified: 2014-04-23 11:58:25 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T64425, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 62425 - wbeditentity permits claim property to be changed, however the diff doesnt display correctly
wbeditentity permits claim property to be changed, however the diff doesnt di...
Status: VERIFIED FIXED
Product: MediaWiki extensions
Classification: Unclassified
WikidataRepo (Other open bugs)
unspecified
All All
: Immediate critical (vote)
: ---
Assigned To: Wikidata bugs
u=dev c=backend p=5 s=2014-04-01
:
Depends on:
Blocks: 62927
  Show dependency tree / graph
 
Reported: 2014-03-08 04:17 UTC by John Mark Vandenberg
Modified: 2014-04-23 11:58 UTC (History)
5 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description John Mark Vandenberg 2014-03-08 04:17:53 UTC 
An API call to wbeditentity, that uses the existing claim guid, is able to change the property of the claim.

See

https://www.wikidata.org/w/index.php?title=Q6240488&diff=114789738&oldid=114788831

In the diff, the presentation assumes the property of the claim is the same before and after.

However in the previous revision, there was a 'title' claim. In the modified revision, there is a 'birth name' claim.

Either the API or the Diff logic is wrong.
Comment 1 Addshore 2014-03-09 13:22:36 UTC 
It would seem the Diff logic is wrong :)
Comment 2 Lydia Pintscher 2014-03-09 19:51:42 UTC 
It should not be possible to change the property.
Comment 4 Gerrit Notification Bot 2014-03-24 15:22:27 UTC 
Change 120537 had a related patch set uploaded by Daniel Kinzler:
(bug 62425) Property of main snak must not change.

https://gerrit.wikimedia.org/r/120537
Comment 5 Aude 2014-03-25 16:09:12 UTC 
note, it's also possible to add a snak with mismatching property data type and data value
Comment 6 Gerrit Notification Bot 2014-04-02 15:14:15 UTC 
Change 120537 merged by jenkins-bot:
(bug 62425) Property of main Snak must not change

https://gerrit.wikimedia.org/r/120537
Comment 7 tobias.gritschacher 2014-04-02 16:16:02 UTC 
(In reply to Aude from comment #5)
> note, it's also possible to add a snak with mismatching property data type
> and data value

this will be solved by bug 62644
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links