Last modified: 2014-11-15 06:08:32 UTC
We have recently encountered several bugs in the old connect / express version we are using: * error reporting recursion when setting headers after they are sent -- worked around in ParsoidService * URL decoding breakage as in http://parsoid-lb.eqiad.wikimedia.org/zhwiki/Alcohol_120% We should consider upgrading either to a newer express version, or use another similar framework like restify. Things to consider / ensure: * form data handling needs to support both urlencoded and multipart/form-data, and should not create temporary files * need continued support for gzip encoding etc * would be nice to have consistent JSON-based error reporting built in, but could also be implemented as a logging backend (although that might not handle errors in the framework)
Rashomon is using restify and busboy, which seems to be working fine.
http://expressjs.com/2x/ now has a big red banner on it which says, "nown and unknown security and performance issues in 2.x have not been addressed since the last update (29 June, 2012). It is highly recommended to upgrade to Express 3.x or to Express 4.x." See also bug 73395.
Change 173481 had a related patch set uploaded by Arlolra: (Bug 62326) WIP: Upgrade express https://gerrit.wikimedia.org/r/173481
