Last modified: 2014-03-10 21:46:53 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T64279, the corresponding Phabricator task for complete and up-to-date bug report information.

Bug 62279 - VisualEditor: [Regression pre-wmf17] Please round image sizes to whole numbers


Summary:	VisualEditor: [Regression pre-wmf17] Please round image sizes to whole numbers

Status:	RESOLVED FIXED

Product:	VisualEditor
Classification:	Unclassified
Component:	Editing Tools (Other open bugs)
Version:	unspecified
Hardware:	All All

Importance:	High minor
Target Milestone:	VE-deploy-2014-03-13
Assigned To:	Moriel Schottlender

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:	ve-mediasupport
	Show dependency tree / graph

Reported:	2014-03-05 21:52 UTC by WhatamIdoing
Modified:	2014-03-10 21:46 UTC (History)
CC List:	5 users (show)

See Also:
Web browser:	---
Mobile Platform:	---
Assignee Huggle Beta Tester:	---

Attachments
Screen shot of VisualEditor's image dialog, under advanced settings (16.99 KB, image/png) 2014-03-05 21:53 UTC, WhatamIdoing	Details
Add an attachment (proposed patch, testcase, etc.)

Description WhatamIdoing 2014-03-05 21:52:55 UTC

Wikitext code:  [[File:Hedrick (1921) - Bartlett.jpg|thumb|Caption]]

Original image dimensions:  920 × 1,216 pixels.

VisualEditor says:  166.32302405498282 × 220 pixels.


Please round to whole numbers of pixels.

Comment 1 WhatamIdoing 2014-03-05 21:53:51 UTC

Created attachment 14746 [details]
Screen shot of VisualEditor's image dialog, under advanced settings

Comment 2 Moriel Schottlender 2014-03-05 22:57:34 UTC

I can't manage to replicate this, not even in betalabs.

http://en.wikipedia.beta.wmflabs.org/wiki/User:Mooeypoo/Test?veaction=edit

I get 166x220 in the media size widget...

Comment 3 Moriel Schottlender 2014-03-06 05:16:05 UTC

I still can't manage to replicate the bug on master or on betalabs, but in any case, height calculations are rounded in this patch: https://gerrit.wikimedia.org/r/#/c/117144/

This should fix instances of this bug.

Comment 4 Moriel Schottlender 2014-03-06 05:17:59 UTC

Apologies, I mean this fix: https://gerrit.wikimedia.org/r/#/c/117161/

(Added Math.round() in the default size conversion in the dm)

Comment 5 Gerrit Notification Bot 2014-03-06 05:20:33 UTC

Change 117161 had a related patch set uploaded by Mooeypoo:
Enforce width-only default size only on larger images

https://gerrit.wikimedia.org/r/117161

Comment 6 Gerrit Notification Bot 2014-03-10 21:32:08 UTC

Change 117161 merged by jenkins-bot:
Enforce width-only default size only on larger images

https://gerrit.wikimedia.org/r/117161

Wikimedia Bugzilla is closed!

Search

Personal tools

Navigation

Links