Last modified: 2014-03-05 21:08:49 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T64198, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 62198 - Mark window.$j as deprecated
Mark window.$j as deprecated
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
JavaScript (Other open bugs)
1.23.0
All All
: Normal normal (vote)
: 1.23.0 release
Assigned To: Tony Thomas
: easy
Depends on:
Blocks: code_quality global-vars
  Show dependency tree / graph
 
Reported: 2014-03-04 13:20 UTC by Helder
Modified: 2014-03-05 21:08 UTC (History)
6 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Helder 2014-03-04 13:20:07 UTC 
This is an old jQuery alias from Usability Initiative times... Can't it be deprecated?
https://github.com/wikimedia/mediawiki-core/blob/master/resources/mediawiki/mediawiki.js#L2354-L2355

Something like this:
mw.log.deprecate( window, '$j', jQuery, 'Use $ or jQuery instead.' );
Comment 1 Bartosz Dziewoński 2014-03-04 13:24:13 UTC 
+1
Comment 2 Gerrit Notification Bot 2014-03-05 11:42:34 UTC 
Change 116946 had a related patch set uploaded by 01tonythomas:
Deprecated window.$j

https://gerrit.wikimedia.org/r/116946
Comment 3 Gerrit Notification Bot 2014-03-05 13:39:51 UTC 
Change 116946 merged by jenkins-bot:
Deprecate window.$j

https://gerrit.wikimedia.org/r/116946
Comment 4 Andre Klapper 2014-03-05 13:46:35 UTC 
Bug is now in 1.23, hence setting the Version field back to 1.23.
When the code was introduced is mostly uninteresting.
Comment 5 Umherirrender 2014-03-05 19:41:16 UTC 
successfully merged
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links