Last modified: 2014-03-10 21:20:18 UTC
1. "frame" thinks you can set a size other than original size, you can't 2. changing from "thumbnail" to "frame" doesn't hide the zoom icon 3. changing from "thumbnail" or "frame" to border doesn't collapse the border 4. "border" images come up as inline so can't be edited, even though you can convert to border from a block image I'm concerned we're merging features before they're ready. We should consider rolling back features that don't fully work yet at is looks like there's a lot still to do.
5. Opening the media dialog editor on a frameless centred image ([[File:Example.jpg|200px|center]]) throws an exception (Cannot call method 'getData' of null ve.ui.MWMediaEditDialog.js:329)
I believe at least some of these are done in Gerrit change #115939.
(In reply to Ed Sanders from comment #0) > 1. "frame" thinks you can set a size other than original size, you can't Fixed. > 2. changing from "thumbnail" to "frame" doesn't hide the zoom icon Not fixed. > 3. changing from "thumbnail" or "frame" to border doesn't collapse the border Fixed. > 4. "border" images come up as inline so can't be edited, even though you can > convert to border from a block image Fixed. (In reply to Ed Sanders from comment #1) > 5. Opening the media dialog editor on a frameless centred image > ([[File:Example.jpg|200px|center]]) throws an exception (Cannot call method > 'getData' of null ve.ui.MWMediaEditDialog.js:329) Fixed. => Re-titling.
Change 117928 had a related patch set uploaded by Mooeypoo: Show/hide the magnify button on type change https://gerrit.wikimedia.org/r/117928
Change 117928 merged by jenkins-bot: Show/hide the magnify button on type change https://gerrit.wikimedia.org/r/117928
