Last modified: 2014-09-23 19:35:53 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T64068, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 62068 - ResourceLoader: Change doesn't invalidate if change only touches a 'skinStyles' file
ResourceLoader: Change doesn't invalidate if change only touches a 'skinStyle...
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
ResourceLoader (Other open bugs)
unspecified
All All
: Normal normal (vote)
: ---
Assigned To: Krinkle
:
Depends on:
Blocks: 54945
  Show dependency treegraph
 
Reported: 2014-02-28 19:20 UTC by Krinkle
Modified: 2014-09-23 19:35 UTC (History)
4 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Krinkle 2014-02-28 19:20:35 UTC
Applying the patch from Ie6b47f5d192953366911 in VisualEditor did not result in a module change update.

I kept refreshing and purging but nothing happened.

Turns out the way we fetch files in #getModifiedTime is broken for 'skinStyles'.

For some reason, this method duplicates the logic to interpret the 'skinStyles' array structure from #getStyleFiles (instead of using that method), and did so incorrectly causing it to always end up with an empty array.

The bug is quite subtle in that the module is capable of including these files (they're not missing from the css build), it's just that the module cache isn't invalidated if a commit only changed files listed in that part of a module.
Comment 1 Gerrit Notification Bot 2014-02-28 19:24:32 UTC
Change 112837 had a related patch set uploaded by Krinkle:
resourceloader: Fix broken skinStyles loop in #getModifiedTime

https://gerrit.wikimedia.org/r/112837
Comment 2 Gerrit Notification Bot 2014-02-28 19:24:37 UTC
Change 116143 had a related patch set uploaded by Krinkle:
[WIP] resourceloader: Regression test for bug 62068

https://gerrit.wikimedia.org/r/116143
Comment 3 Gerrit Notification Bot 2014-02-28 20:09:11 UTC
Change 112837 merged by jenkins-bot:
resourceloader: Fix broken skinStyles loop in #getModifiedTime

https://gerrit.wikimedia.org/r/112837
Comment 4 Gerrit Notification Bot 2014-09-23 19:35:53 UTC
Change 116143 abandoned by Krinkle:
[WIP] resourceloader: Regression test for bug 62068

https://gerrit.wikimedia.org/r/116143

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links