Last modified: 2011-03-13 18:04:38 UTC
In User.php the function isIP verifies f.e. 300.300.300.300 as IP address. Attached you will find a patch that will only verify valid IP (v4) addresses. The patched function still verifies usemod usernames (see bug 3631). Regards, Jiimmy
Created attachment 1899 [details] User.php.patch (trunk)
As the source says: * Note: We match \d{1,3}\.\d{1,3}\.\d{1,3}\.xxx as an anonymous IP * address because the usemod software would "cloak" anonymous IP * addresses like this, if we allowed accounts like this to be created * new users could get the old edits of these anonymous users. As far as I'm concerned, User::isIP() has two purposes: to prevent users registering usernames which conflict with IP addresses, and to prevent registration of names which are confusingly similar to IP addresses. If you need to perform only the first task for some reason, you can use wfIP2Unsigned($ip) !== false.
(In reply to comment #2) > ... and to prevent prevent registration of names which are confusingly similar to IP addresses. Tim, if this is wanted, a little comment in the source would be helpfull. As far as I'm concerned this function sould verfiy a valid IP address (except $.$.$.xxx).
Updated the comment in the source, not a bug, closing as wontfix.
