Last modified: 2014-05-20 20:10:24 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T63761, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 61761 - TemplateData: TemplateDataGenerator causes dirty diffs by always adding optional parameter’s property 'required'
TemplateData: TemplateDataGenerator causes dirty diffs by always adding optio...
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
TemplateData (Other open bugs)
unspecified
All All
: High minor (vote)
: ---
Assigned To: Ltrlg
:
Depends on:
Blocks: td-gui-stable
  Show dependency treegraph
 
Reported: 2014-02-21 19:26 UTC by Ltrlg
Modified: 2014-05-20 20:10 UTC (History)
4 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Ltrlg 2014-02-21 19:26:40 UTC
According to the last version of spec.templatedata.json, 'required' is optional and defaults to false.

If I have the following JSON:
{
	"params": {
		"myparam": {
			"description": "Here should be a description"
		}
	}
}

TDG will replace it (when applying without changing anything) with
{
	"params": {
		"myparam": {
			"description": "Here should be a description",
			"required": false
		}
	},
	"description": ""
}

When you’ve edited a big template documentation that didn’t have any 'required' set, that’s really hard to read
Comment 1 Gerrit Notification Bot 2014-02-21 19:59:48 UTC
Change 114770 had a related patch set uploaded by Ltrlg:
Do not add 'required' if not set and false wanted

https://gerrit.wikimedia.org/r/114770
Comment 2 Gerrit Notification Bot 2014-03-07 23:27:52 UTC
Change 114770 merged by jenkins-bot:
Do not add 'required' if not set and false wanted

https://gerrit.wikimedia.org/r/114770

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links