Last modified: 2014-09-16 10:15:01 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T63630, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 61630 - SemanticForms should pass jshint
SemanticForms should pass jshint
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
SemanticForms (Other open bugs)
master
All All
: Unprioritized normal (vote)
: ---
Assigned To: Yaron Koren
:
Depends on:
Blocks: jshint
  Show dependency tree / graph
 
Reported: 2014-02-20 13:46 UTC by Antoine "hashar" Musso (WMF)
Modified: 2014-09-16 10:15 UTC (History)
0 users

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Antoine "hashar" Musso (WMF) 2014-02-20 13:46:43 UTC 
jshint reports failure on javascript files and should be fixed. Whenever this is done, one can make the jslint job to be voting by editing integration/zuul-config.git layout.yaml file and remove the line that make the jslint job to be non voting.
Comment 1 Gerrit Notification Bot 2014-08-05 21:09:18 UTC 
Change 151970 had a related patch set uploaded by Jatin:
Making SF pass JSHint test

https://gerrit.wikimedia.org/r/151970
Comment 2 Gerrit Notification Bot 2014-08-15 13:27:22 UTC 
Change 151970 merged by Yaron Koren:
Making SF pass JSHint test

https://gerrit.wikimedia.org/r/151970
Comment 3 Yaron Koren 2014-08-15 13:51:46 UTC 
hashar - can you confirm if this is now fixed?
Comment 4 Gerrit Notification Bot 2014-09-16 10:13:42 UTC 
Change 160623 had a related patch set uploaded by Hashar:
SemanticForms now pass jshint make it voting

https://gerrit.wikimedia.org/r/160623
Comment 5 Gerrit Notification Bot 2014-09-16 10:14:05 UTC 
Change 160623 merged by jenkins-bot:
SemanticForms now pass jshint make it voting

https://gerrit.wikimedia.org/r/160623
Comment 6 Antoine "hashar" Musso (WMF) 2014-09-16 10:15:01 UTC 
Thanks Yaron! It even has a .jshintrc file.

I have made the Jenkins job voting :-)
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links