Last modified: 2014-02-20 20:08:58 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T63621, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 61621 - RSS should pass jshint
RSS should pass jshint
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
RSS (Other open bugs)
master
All All
: Low normal (vote)
: ---
Assigned To: T. Gries
:
Depends on:
Blocks: jshint
  Show dependency tree / graph
 
Reported: 2014-02-20 13:42 UTC by Antoine "hashar" Musso (WMF)
Modified: 2014-02-20 20:08 UTC (History)
2 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Antoine "hashar" Musso (WMF) 2014-02-20 13:42:22 UTC 
jshint reports failure on javascript files and should be fixed. Whenever this is done, one can make the jslint job to be voting by editing integration/zuul-config.git layout.yaml file and remove the line that make the jslint job to be non voting.
Comment 1 T. Gries 2014-02-20 18:41:39 UTC 
(In reply to Antoine "hashar" Musso from comment #0)
> jshint reports failure on javascript files and should be fixed. Whenever
> this is done, one can make the jslint job to be voting by editing
> integration/zuul-config.git layout.yaml file and remove the line that make
> the jslint job to be non voting.

Can you give send me link, or screenshot, what exactly you mean ?
Comment 2 T. Gries 2014-02-20 19:53:37 UTC 
"hashar": let me know, what is wrong and I will fix it as soon as possible !!!! !!!!!
Comment 3 Gerrit Notification Bot 2014-02-20 20:05:42 UTC 
Change 114526 had a related patch set uploaded by Hashar:
mwext-RSS-jslint has no .js, make it voting

https://gerrit.wikimedia.org/r/114526
Comment 4 Gerrit Notification Bot 2014-02-20 20:06:36 UTC 
Change 114526 merged by jenkins-bot:
mwext-RSS-jslint has no .js, make it voting

https://gerrit.wikimedia.org/r/114526
Comment 5 Antoine "hashar" Musso (WMF) 2014-02-20 20:08:22 UTC 
The RSS extensions has no javascript file, hence the Jenkins job http://integration.wikimedia.org/ci/job/mwext-RSS-jslint/? (which runs jshint) never got triggered.

I made it to vote, so whenever a Javascript file is added and does not pass jshint it will vote Verified -1.

Thank you and sorry for the trouble.
Comment 6 T. Gries 2014-02-20 20:08:58 UTC 
1.000.000 thx!
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links