Last modified: 2014-02-20 15:11:03 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T63590, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 61590 - CleanChanges should pass jshint
CleanChanges should pass jshint
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
CleanChanges (Other open bugs)
master
All All
: Unprioritized normal (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks: jshint
  Show dependency tree / graph
 
Reported: 2014-02-20 13:26 UTC by Antoine "hashar" Musso (WMF)
Modified: 2014-02-20 15:11 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Antoine "hashar" Musso (WMF) 2014-02-20 13:26:16 UTC 
jshint reports failure on javascript files and should be fixed. Whenever this is done, one can make the jslint job to be voting by editing integration/zuul-config.git layout.yaml file and remove the line that make the jslint job to be non voting.
Comment 1 Niklas Laxström 2014-02-20 14:29:49 UTC 
I can't see any failures.
Comment 2 Antoine "hashar" Musso (WMF) 2014-02-20 14:44:43 UTC 
The job is failing though:

 http://integration.wikimedia.org/ci/job/mwext-CleanChanges-jslint/

I guess it is because there is no jshintrc and hence it fallback to the default one we provide (bug 52456).
Comment 3 Gerrit Notification Bot 2014-02-20 15:03:41 UTC 
Change 114471 had a related patch set uploaded by Hashar:
Ensure jshint uses default settings

https://gerrit.wikimedia.org/r/114471
Comment 4 Antoine "hashar" Musso (WMF) 2014-02-20 15:07:34 UTC 
Due to bug 52456, we have to ship an empty .jshintrc file. The job pass now :-]
Comment 5 Gerrit Notification Bot 2014-02-20 15:07:47 UTC 
Change 114471 merged by jenkins-bot:
Ensure jshint uses default settings

https://gerrit.wikimedia.org/r/114471
Comment 6 Gerrit Notification Bot 2014-02-20 15:10:13 UTC 
Change 114472 had a related patch set uploaded by Hashar:
mwext-CleanChanges-jslint is now voting

https://gerrit.wikimedia.org/r/114472
Comment 7 Gerrit Notification Bot 2014-02-20 15:10:36 UTC 
Change 114472 merged by jenkins-bot:
mwext-CleanChanges-jslint is now voting

https://gerrit.wikimedia.org/r/114472
Comment 8 Antoine "hashar" Musso (WMF) 2014-02-20 15:11:03 UTC 
jshint is passing and the job is now voting :-]
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links