Last modified: 2014-04-18 12:21:31 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T63509, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 61509 - Have an i18n CI job that ensures there's a qqq message for each en message
Have an i18n CI job that ensures there's a qqq message for each en message
Status: RESOLVED FIXED
Product: Wikimedia
Classification: Unclassified
Continuous integration (Other open bugs)
unspecified
All All
: Normal enhancement (vote)
: ---
Assigned To: James Forrester
:
Depends on:
Blocks: 55456
  Show dependency tree / graph
 
Reported: 2014-02-18 20:02 UTC by James Forrester
Modified: 2014-04-18 12:21 UTC (History)
4 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description James Forrester 2014-02-18 20:02:23 UTC 
For projects built with npm (e.g. VE, OOjs UI) this could be relatively easy, but for MW core I imagine it's a bit harder to parse .php files.

(For VE we'd want this blocking merge, but that's a distinct conversation.)
Comment 1 Antoine "hashar" Musso (WMF) 2014-02-24 11:40:09 UTC 
For mediawiki/core I once wrote a test suite that compares messages in messages.inc, en and qqq https://gerrit.wikimedia.org/r/#/c/5550/

They are not passing though and I don't really have the mood to complete this patch though :-(
Comment 2 Gerrit Notification Bot 2014-02-24 11:40:23 UTC 
Change 5550 had a related patch set uploaded by Hashar:
tests to compare En, Qqq and messages.inc

https://gerrit.wikimedia.org/r/5550
Comment 3 Gerrit Notification Bot 2014-04-15 21:14:59 UTC 
Change 125050 had a related patch set uploaded by Jforrester:
Use new banana checker as a linter to avoid lacking qqq messages

https://gerrit.wikimedia.org/r/125050
Comment 4 James Forrester 2014-04-15 22:13:32 UTC 
Done in https://www.npmjs.org/package/grunt-banana-checker – Gerrit change #125050 adds this to MediaWiki core; Gerrit change #124069, Gerrit change #124023 and Gerrit change #124021 added it to OOjs UI, VisualEditor, and VisualEditor-MediaWiki.
Comment 5 Gerrit Notification Bot 2014-04-15 22:13:58 UTC 
Change 5550 abandoned by Jforrester:
tests to compare En, Qqq and messages.inc

Reason:
Replaced by https://www.npmjs.org/package/grunt-banana-checker now.

https://gerrit.wikimedia.org/r/5550
Comment 6 Antoine "hashar" Musso (WMF) 2014-04-16 09:23:39 UTC 
(In reply to Gerrit Notification Bot from comment #5)
> Change 5550 abandoned by Jforrester:
> tests to compare En, Qqq and messages.inc
> 
> Reason:
> Replaced by https://www.npmjs.org/package/grunt-banana-checker now.
> 
> https://gerrit.wikimedia.org/r/5550

Sounds good to me :-]
Comment 7 Gerrit Notification Bot 2014-04-16 23:51:20 UTC 
Change 125050 merged by jenkins-bot:
Use new banana checker as a linter to avoid lacking qqq messages

https://gerrit.wikimedia.org/r/125050
Comment 8 Antoine "hashar" Musso (WMF) 2014-04-17 07:26:13 UTC 
Other repositories (i.e. MediaWiki extensions) will be checked using a dedicated Jenkins job. That is the purpose of bug 64045.
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links