Last modified: 2014-09-02 17:00:41 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T63072, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 61072 - VisualEditor: Apply styles for redirects/disambiguation links in suggestions in link inspector
VisualEditor: Apply styles for redirects/disambiguation links in suggestions ...
Status: ASSIGNED
Product: VisualEditor
Classification: Unclassified
Editing Tools (Other open bugs)
unspecified
All All
: Lowest trivial
: ---
Assigned To: Editing team bugs – take if you're interested!
:
: 64584 (view as bug list)
Depends on: 166 7936
Blocks: ve-linkediting
  Show dependency treegraph
 
Reported: 2014-02-08 00:15 UTC by Roan Kattouw
Modified: 2014-09-02 17:00 UTC (History)
10 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Roan Kattouw 2014-02-08 00:15:36 UTC
We apply red link styles to nonexistent titles in the link suggestions, so for redirects and disambig pages the corresponding styles/classes should be applied as well.

I don't actually know what these are, ask James :)
Comment 1 James Forrester 2014-05-30 02:38:54 UTC
*** Bug 64584 has been marked as a duplicate of this bug. ***
Comment 2 Bartosz Dziewoński 2014-07-31 13:35:05 UTC
We actually don't apply any classes, ve.ui.MWLinkTargetInputWidget.css just has some styles defining a close-enough reddish color. (This is kind of bad since the color can differ per-skin.)

.ve-ui-mwLinkTargetInputWidget-menu .oo-ui-menuItemWidget[rel=newPage] {
	color: #BA0000;
}

There are no styles by default for redirect and disambiguation links, some users choose to style them in various ways (usually green for redirects and maroon for disambigs). 

I'm not sure if we should do this for the link in the inspector; they are already visually distinct by being placed in separate sections. We might want to remove the reddish styles too...
Comment 3 James Forrester 2014-07-31 15:45:49 UTC
(In reply to Bartosz Dziewoński from comment #2)
> We actually don't apply any classes, ve.ui.MWLinkTargetInputWidget.css just
> has some styles defining a close-enough reddish color. (This is kind of bad
> since the color can differ per-skin.)
> 
> .ve-ui-mwLinkTargetInputWidget-menu .oo-ui-menuItemWidget[rel=newPage] {
> 	color: #BA0000;
> }
> 
> There are no styles by default for redirect and disambiguation links, some
> users choose to style them in various ways (usually green for redirects and
> maroon for disambigs). 

Presumably the styles will be ported over to Parsoid content, at which point we can just apply them directly?


> I'm not sure if we should do this for the link in the inspector; they are
> already visually distinct by being placed in separate sections. We might
> want to remove the reddish styles too...

I'm not sure. Consistency of hinting is important.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links