Last modified: 2014-02-08 22:08:16 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T62991, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 60991 - Vector skin gradient broken in IE6-9
Vector skin gradient broken in IE6-9
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
Interface (Other open bugs)
1.23.0
All All
: Normal normal (vote)
: 1.23.0 release
Assigned To: Erwin Dokter
:
: 61020 (view as bug list)
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-02-06 21:07 UTC by Isarra
Modified: 2014-02-08 22:08 UTC (History)
5 users (show)

See Also:
Web browser: Internet Explorer
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Isarra 2014-02-06 21:07:18 UTC
Currently there's no gradient at all at the top of the page, because the gradient mixin is missing the filter for gradient support in IE6-9.

It'd be something messy like this:
filter: progid:DXImageTransform.Microsoft.gradient( startColorstr='@startColor', endColorstr='@endColor',GradientType=0 );

More on this later when I can feel my hands.
Comment 1 Isarra 2014-02-07 06:31:06 UTC
So using the filter, Vector explodes in IE6-9. (Bug 61008)

Fix that, and it turns out the filter also causes the top border of the content block in Vector to disappear for some reason.

The filter also does not seem to support stop positioning or having more than two stops. This means that for IE6-9, fixing Bug 60943 would be impossible the way Vector is currently set up.
Comment 2 Bartosz Dziewoński 2014-02-07 12:24:50 UTC
*** Bug 61020 has been marked as a duplicate of this bug. ***
Comment 3 Erwin Dokter 2014-02-07 13:19:29 UTC
All it needs is a fallback to the old PNG background. Don't mess with IE filters.
Comment 4 Erwin Dokter 2014-02-07 13:59:17 UTC
I have a patch ready, but I am unable to 'undelete' /skins/vector/images/page-base.png in the patch. I can attach it here, but also want to check if this is correct. Basically, I have added a PNG fallback for IE 6-9:

-	.vertical-gradient(@body-background-color, @menu-background-color, 40%, 100%);
+	background-image: url('images/page-fade.png');
+	.vertical-gradient(@body-background-color, @menu-background-color, 50%, 100%);

If this is correct, I can attach the patch here.
Comment 5 Erwin Dokter 2014-02-07 13:59:45 UTC
It also contains a fix for bug 60943.
Comment 6 Andre Klapper 2014-02-07 14:03:44 UTC
Erwin: Putting the patch into Gerrit is very welcome! See https://www.mediawiki.org/wiki/Developer_access
Comment 7 Erwin Dokter 2014-02-07 14:20:57 UTC
I know, but I have trouble creating a patch that includes the image (page-fade.png btw, not page-base.png).

Tried it anyway, but you may have to correct it. Gerrit change #112025.
Comment 8 Gerrit Notification Bot 2014-02-07 14:31:52 UTC
Change 112025 had a related patch set uploaded by Bartosz Dziewoński:
Vector: Restore page-fade.png as fallback background-image for IE 6-9

https://gerrit.wikimedia.org/r/112025
Comment 9 Bartosz Dziewoński 2014-02-07 14:34:45 UTC
(The patch was actually uploaded by Erwin.)
Comment 10 Gerrit Notification Bot 2014-02-07 14:38:41 UTC
Change 112025 had a related patch set uploaded by Bartosz Dziewoński:
Vector: Restore page-fade.png as fallback background-image for IE 6-9

https://gerrit.wikimedia.org/r/112025
Comment 11 Bartosz Dziewoński 2014-02-08 22:08:16 UTC
The basic fix is merged for now. (Note that some discussion was, for some reason, on bug 60943 instead of here.)

I filed bug 61099 about doing this properly. :)

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links