Last modified: 2014-10-20 22:01:42 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T62939, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 60939 - Please enable ULS webfonts by default at Hebrew Wikisource
Please enable ULS webfonts by default at Hebrew Wikisource
Status: RESOLVED FIXED
Product: Wikimedia
Classification: Unclassified
Site requests (Other open bugs)
unspecified
All All
: Normal enhancement (vote)
: ---
Assigned To: Tomasz W. Kozlowski
: i18n, shell
Depends on:
Blocks: 60329
  Show dependency treegraph
 
Reported: 2014-02-06 04:25 UTC by Dovi Jacobs
Modified: 2014-10-20 22:01 UTC (History)
19 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Comment 1 Gerrit Notification Bot 2014-02-24 13:28:56 UTC
Change 115153 had a related patch set uploaded by Odder:
Enable web fonts by default on Hebrew Wikisource

https://gerrit.wikimedia.org/r/115153
Comment 2 Gerrit Notification Bot 2014-03-12 17:32:30 UTC
Change 115153 abandoned by Odder:
Enable web fonts by default on Hebrew Wikisource

https://gerrit.wikimedia.org/r/115153
Comment 3 Gerrit Notification Bot 2014-03-15 12:28:32 UTC
Change 115153 restored by Ori.livneh:
Enable web fonts by default on Hebrew Wikisource

Reason:
If this was abandoned because I was being impolite or unhelpful, let me try and rectify that.

https://gerrit.wikimedia.org/r/115153
Comment 4 Ori Livneh 2014-03-16 10:54:16 UTC
There is now some useful discussion in the comments on the patch. So please refer to it if you savvy about this subject.
Comment 5 Dovi Jacobs 2014-03-19 12:30:45 UTC
Hi, I now see the relevant texts appearing in a new font, both when I am signed in and when I am not. Does this mean the patch has been implemented?

The font, however, is not the same one as previously (which was a better one).
Comment 6 Nemo 2014-03-19 12:59:26 UTC
(In reply to Dovi Jacobs from comment #5)
> Hi, I now see the relevant texts appearing in a new font, both when I am
> signed in and when I am not. Does this mean the patch has been implemented?

No.

> 
> The font, however, is not the same one as previously (which was a better
> one).

The font is defined in the MediaWiki scripts of your wiki. You can ask the sysops to change it; no idea what fonts are available by the same means.
Comment 7 Tomasz W. Kozlowski 2014-04-02 18:01:32 UTC
There is a patch in Gerrit solving this issue that awaits merging.
Comment 8 Niklas Laxström 2014-04-02 18:05:00 UTC
Please note that there is interim CSS solution present on the wiki for one language: https://he.wikisource.org/wiki/%D7%9E%D7%93%D7%99%D7%94_%D7%95%D7%99%D7%A7%D7%99:Common.css
Comment 9 dalilonim 2014-04-11 23:17:02 UTC
hello, im new to these pages but if i understand right i would like to comment that adding a personal css code is not the solution we seek. we want our readers also to get a better interface. as i understood there shouldn't be any Times New Roman font but the font still appears on screen as well as in css font families, and it doesn't merge with the rest. if i didn't understood the suggestion, i apologies.  i've been asked to file a report. i hope im in the right page ^_^ 
tnx,
~~~~
Comment 10 Amir E. Aharoni 2014-04-13 14:21:56 UTC
(In reply to dalilonim from comment #9)
> hello, im new to these pages but if i understand right i would like to
> comment that adding a personal css code is not the solution we seek. we want
> our readers also to get a better interface. as i understood there shouldn't
> be any Times New Roman font but the font still appears on screen as well as
> in css font families, and it doesn't merge with the rest. if i didn't
> understood the suggestion, i apologies.  i've been asked to file a report. i
> hope im in the right page ^_^ 
> tnx,
> ~~~~

dalilonim, If you are talking about a change that affected Wikipedia in all languages, then this is not the right place for this. Better go here:
https://www.mediawiki.org/wiki/Talk:Typography_refresh
Comment 11 Amir E. Aharoni 2014-04-13 14:25:37 UTC
About this particular issue: My understanding is that the Hebrew Wikisource needs more than just one font. It uses several fonts for several types of texts, and the "Alef" is not the most important. Hebrew Wikisource is mostly about classical religious texts, which need special diacritics, and for that ULS provides Taamey Frank CLM. It uses the "Alef" for other purposes, too. Does he.wikisource use a lot of fonts for other languages? - no, but all the more, is it a problem to simply enable webfonts so that the Hebrew ones would be loaded in a robust way and not through common.css hacks?
Comment 12 dalilonim 2014-04-13 14:50:19 UTC
(In reply to Amir E. Aharoni from comment #10)
> (In reply to dalilonim from comment #9)
> > hello, im new to these pages but if i understand right i would like to
> > comment that adding a personal css code is not the solution we seek. we want
> > our readers also to get a better interface. as i understood there shouldn't
> > be any Times New Roman font but the font still appears on screen as well as
> > in css font families, and it doesn't merge with the rest. if i didn't
> > understood the suggestion, i apologies.  i've been asked to file a report. i
> > hope im in the right page ^_^ 
> > tnx,
> > ~~~~
> 
> dalilonim, If you are talking about a change that affected Wikipedia in all
> languages, then this is not the right place for this. Better go here:
> https://www.mediawiki.org/wiki/Talk:Typography_refresh

: hello amir,
i replayed to the comment abouve #9, miss understood it as a personal solution. if needed my comment can be deleted.
Comment 13 Tomasz W. Kozlowski 2014-04-13 15:49:44 UTC
(In reply to Amir E. Aharoni from comment #11)

> is it a problem to simply enable webfonts so that the Hebrew ones
> would be loaded in a robust way and not through common.css hacks?

I submitted my patch on February 24 (48 days ago), so yes, I dare say it is a problem.
Comment 14 dalilonim 2014-04-13 15:54:42 UTC
(In reply to dalilonim from comment #12)
> (In reply to Amir E. Aharoni from comment #10)
> > (In reply to dalilonim from comment #9)
> > > hello, im new to these pages but if i understand right i would like to
> > > comment that adding a personal css code is not the solution we seek. we want
> > > our readers also to get a better interface. as i understood there shouldn't
> > > be any Times New Roman font but the font still appears on screen as well as
> > > in css font families, and it doesn't merge with the rest. if i didn't
> > > understood the suggestion, i apologies.  i've been asked to file a report. i
> > > hope im in the right page ^_^ 
> > > tnx,
> > > ~~~~
> > 
> > dalilonim, If you are talking about a change that affected Wikipedia in all
> > languages, then this is not the right place for this. Better go here:
> > https://www.mediawiki.org/wiki/Talk:Typography_refresh
> 
> : hello amir,
> i replayed to the comment abouve #9, miss understood it as a personal
> solution. if needed my comment can be deleted. and the answer is no, it's about hebrew fonts. i already filed specific report on the issue i mentioned.
Comment 15 Gerrit Notification Bot 2014-04-16 17:02:14 UTC
Change 115153 merged by jenkins-bot:
Enable web fonts by default on Hebrew Wikisource

https://gerrit.wikimedia.org/r/115153
Comment 16 Tomasz W. Kozlowski 2014-04-16 17:09:12 UTC
Thanks for the merge, Ori.
Comment 17 Dovi Jacobs 2014-04-17 17:50:01 UTC
Hi, I don't think I understand the end of the discussion here (from Amir's comment and on).

What we are looking for is automatic ULS loading of appropriate fonts for regular text, as well as for texts with diacritical marks labeled "hbo" (and probably the same font or another good alternative for modern texts with niqqud).

So far I don't see any change in the performance of the website, and the font which appears (I don't know its name) is terrible...
Comment 18 Amir E. Aharoni 2014-04-19 17:34:05 UTC
I cleaned up the CSS. Is it better now?
Comment 19 Dovi Jacobs 2014-04-19 18:19:55 UTC
Thanks Amir (and Chag Sameach).

Now I am getting the following: When logged in, it shows the appropriate font (the same one as when ULS was first working). But when not logged in it shows some sort of a standard font that isn't so great for diacriticals.

In other words, something still seems missing in terms of the text showing up in the correct font for anyone who views the page.
Comment 20 Ori Livneh 2014-04-19 20:11:20 UTC
(In reply to Amir E. Aharoni from comment #18)
> I cleaned up the CSS.

Thanks for doing that; I meant to, but forgot.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links