Last modified: 2014-07-02 23:23:47 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T62872, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 60872 - Migrate https://toolserver.org/~erwin85/relatedchanges.php to Tool Labs
Migrate https://toolserver.org/~erwin85/relatedchanges.php to Tool Labs
Status: RESOLVED FIXED
Product: Tool Labs tools
Classification: Unclassified
Erwin's tools (Other open bugs)
unspecified
All All
: Unprioritized normal
: ---
Assigned To: Andre Koopal
:
Depends on:
Blocks: 58865
  Show dependency treegraph
 
Reported: 2014-02-05 11:08 UTC by Magnus Manske
Modified: 2014-07-02 23:23 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Magnus Manske 2014-02-05 11:08:43 UTC
Code is already on Labs, "just" needs to be fixed to run there. Please join the tool "erwin85" there and help!

http://tools.wmflabs.org/erwin85/
Comment 1 Andre Koopal 2014-03-25 19:15:48 UTC
I have had a quick look into this, as I am interested in the tool. Main problem seems to be it uses an old style personal database: u_erwin85.sc_ for caching of the category tree. This seems to be a quick fix, but will need some changes in the include file as well.

Certainly willing to look better into this, my toollabs login is akoopal.
Comment 2 Magnus Manske 2014-03-25 22:55:40 UTC
Andre, I have added you as a tool maintainer. Have fun! :-)
Comment 3 Andre Koopal 2014-03-26 00:11:08 UTC
Working on this now
Comment 4 Andre Koopal 2014-03-26 09:52:26 UTC
Related changes is working, database u_erwin85 replaced with <sqluser>__erwin85 overall and created that database on all database servers. Some quick testing shows most is working, however for commons I get mysql errors. Have looked at the exceptions made for those databases, and I don't see what can be wrong. A second look would be appreciated.
Comment 5 Helder 2014-06-18 17:01:36 UTC
As reported on
https://pt.wikipedia.org/w/index.php?diff=39171644&oldid=39162195&uselang=en
the tool seems to be displaying edits made to Wikidata items when the user selects the Portuguese Wikipedia. E.g.:
https://tools.wmflabs.org/erwin85/relatedchanges.php?lang=pt&family=wikipedia&category=Xadrez&d=10&submit=Submit
shows an item like this:
----
(<a href="//pt.wikipedia.org/w/index.php?title=Gregory Hjorth&amp;diff=prev&amp;oldid=37957133" title="" tabindex="1">diff</a>) (<a href="//pt.wikipedia.org/w/index.php?title=Gregory Hjorth&amp;action=history" title="">hist</a>) . . <span class="minor">m</span> <a href="//pt.wikipedia.org/wiki/Gregory Hjorth" title="Gregory Hjorth">Gregory Hjorth</a>‎ 11:37. . <a href="//pt.wikipedia.org/wiki/User:Haplology" title="User:Haplology">Haplology</a> (<a href="//pt.wikipedia.org/wiki/User_talk:Haplology" title="User talk:Haplology">Talk</a> | <a href="//pt.wikipedia.org/wiki/Special:Contributions/Haplology" title="Special:Contributions/Haplology">contribs</a>) 
----
but Haplology did not edit Portuguese Wikipedia
https://pt.wikipedia.org/wiki/Special:Contribs/Haplology?uselang=en
and Wikidata shows an edit to the associated item
https://www.wikidata.org/w/index.php?diff=138666564

Ideally, edits to Wikidata whould not be diplayed in this case, or if they do, at the very least the diff and hist links should be fixed to point to the Wikidata edit/history.
Comment 6 Andre Koopal 2014-06-18 17:25:35 UTC
I know the issue, at the moment I don't have time to look into this in detail, if I make time I first want to look at why commons is not connecting, and look at making Erwin's other tools work, then I want to look at these kind of things. So if others want to look into this, appreciated.

Quick fix is to just suppress the wikidata edits, better solution would be to mark them as wikidata-edits, link properly to wikidata and make a switch to choose.
Comment 7 Andre Koopal 2014-06-20 12:40:33 UTC
I have split of the report above to bug 66874, as it is a different issue.
Comment 8 This, that and the other (TTO) 2014-07-02 11:23:55 UTC
The tool has been migrated, so I'm closing this bug. Any further issues should be reported as separate bugs.

https://tools.wmflabs.org/erwin85/relatedchanges.php
Comment 9 Andre Koopal 2014-07-02 23:23:47 UTC
As it wasn't working on commons after migration, I still considered it not completely migrated. But I have find the cause and it is working now. Just documenting here to be sure.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links