Last modified: 2014-09-25 21:55:55 UTC
Created attachment 14486 [details] link text appearing for the second time Steps to reproduce: 1.Select a math function/image/gallery/hiero 2.Now open the link inspector 3.Insert a link (this link gets placed just before the selected element) 4.Again select the element 5.Open the link inserter 6.Observe that the link title of the previous link is appearing now in the link inspector 7.Close the link inspector. Observed Result: The link text title of the previous link is getting inserted just before the selected element. See the screenshot attached. Test Environment: https://test2.wikipedia.org/ Browser: Chrome Version 26.0.1410.65 & FF 25 OS: MAC OS X 10. 8. 5 Page:https://test2.wikipedia.org/wiki/Image_then_gallery?veaction=edit
Created attachment 14487 [details] link text getting added before math function
Change 138114 had a related patch set uploaded by Catrope: [BREAKING CHANGE] Update VE core submodule to master (43a48cb) for window process cleanup https://gerrit.wikimedia.org/r/138114
Change 138114 merged by jenkins-bot: [BREAKING CHANGE] Update VE core submodule to master (43a48cb) for window process cleanup https://gerrit.wikimedia.org/r/138114
This is not yet fixed.The link text is still getting added next to the previously added link
Selection's not being re-set to the actual link (of the pre-annotation stack or something odd)?
Roan says the fix is to fix the pre-population of the link inspector in create mode. I think.
I think this is fixed now? I can't reproduce it any more...
Confirmed fixed in master but not in wmf18.
Never mind, I'm an idiot. It's still broken if you try to inspect the same reference with the link inspector twice in a row.
I can't reproduce. Probably fixed by Ed's recent cleanup of the link inspector.
Verified the fix in Betalabs
Verified the fix in test2
Verified the fix in production