Last modified: 2014-09-25 21:55:55 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T62843, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 60843 - VisualEditor: Link inspector is adding just a link text while opening up the inspector for the second time selecting another element
VisualEditor: Link inspector is adding just a link text while opening up the ...
Status: VERIFIED FIXED
Product: VisualEditor
Classification: Unclassified
Editing Tools (Other open bugs)
unspecified
All All
: High normal
: VE-deploy-2014-09-18
Assigned To: Roan Kattouw
:
Depends on:
Blocks: ve-linkediting
  Show dependency treegraph
 
Reported: 2014-02-04 20:06 UTC by Rummana Yasmeen
Modified: 2014-09-25 21:55 UTC (History)
7 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
link text appearing for the second time (12.91 KB, image/png)
2014-02-04 20:06 UTC, Rummana Yasmeen
Details
link text getting added before math function (129.12 KB, image/png)
2014-02-04 20:07 UTC, Rummana Yasmeen
Details

Description Rummana Yasmeen 2014-02-04 20:06:57 UTC
Created attachment 14486 [details]
link text appearing for the second time

Steps to reproduce:

1.Select a math function/image/gallery/hiero
2.Now open the link inspector
3.Insert a link (this link gets placed just before the selected element)
4.Again select the element
5.Open the link inserter
6.Observe that the link title of the previous link is appearing now in the link inspector
7.Close the link inspector.

Observed Result:
The link text title of the previous link is getting inserted just before the selected element.

See the screenshot attached.

Test Environment: https://test2.wikipedia.org/
Browser: Chrome Version 26.0.1410.65 & FF 25
OS: MAC OS X 10. 8. 5 
Page:https://test2.wikipedia.org/wiki/Image_then_gallery?veaction=edit
Comment 1 Rummana Yasmeen 2014-02-04 20:07:57 UTC
Created attachment 14487 [details]
link text getting added before math function
Comment 2 Gerrit Notification Bot 2014-06-12 00:42:15 UTC
Change 138114 had a related patch set uploaded by Catrope:
[BREAKING CHANGE] Update VE core submodule to master (43a48cb) for window process cleanup

https://gerrit.wikimedia.org/r/138114
Comment 3 Gerrit Notification Bot 2014-06-12 00:44:13 UTC
Change 138114 merged by jenkins-bot:
[BREAKING CHANGE] Update VE core submodule to master (43a48cb) for window process cleanup

https://gerrit.wikimedia.org/r/138114
Comment 4 Rummana Yasmeen 2014-06-13 22:57:55 UTC
This is not yet fixed.The link text is still getting added next to the previously added link
Comment 5 James Forrester 2014-07-21 19:02:27 UTC
Selection's not being re-set to the actual link (of the pre-annotation stack or something odd)?
Comment 6 James Forrester 2014-07-23 19:48:50 UTC
Roan says the fix is to fix the pre-population of the link inspector in create mode. I think.
Comment 7 Roan Kattouw 2014-08-22 06:57:56 UTC
I think this is fixed now? I can't reproduce it any more...
Comment 8 James Forrester 2014-08-22 18:37:52 UTC
Confirmed fixed in master but not in wmf18.
Comment 9 Roan Kattouw 2014-08-22 18:40:36 UTC
Never mind, I'm an idiot. It's still broken if you try to inspect the same reference with the link inspector twice in a row.
Comment 10 Bartosz Dziewoński 2014-09-17 11:56:45 UTC
I can't reproduce. Probably fixed by Ed's recent cleanup of the link inspector.
Comment 11 Rummana Yasmeen 2014-09-17 19:20:34 UTC
Verified the fix in Betalabs
Comment 12 Rummana Yasmeen 2014-09-18 23:21:15 UTC
Verified the fix in test2
Comment 13 Rummana Yasmeen 2014-09-25 21:55:55 UTC
Verified the fix in production

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links