Last modified: 2014-04-22 20:44:42 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T62809, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 60809 - Flow: API to determine if Flow is enabled on a page
Flow: API to determine if Flow is enabled on a page
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
Flow (Other open bugs)
master
All All
: Normal normal (vote)
: ---
Assigned To: Kunal Mehta (Legoktm)
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-02-04 04:10 UTC by spage
Modified: 2014-04-22 20:44 UTC (History)
7 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description spage 2014-02-04 04:10:47 UTC
It seems useful to provide some API to determine if Flow is enabled on a page, since that affects whether many API actions will work or make sense (bug 60808).

The equivalent for LiquidThreads is it returns use-liquid-threads="1" in pageprops queries.  Compare LQT page:
  https://www.mediawiki.org/w/api.php?action=query&prop=pageprops&titles=Talk:Flow_Portal/Archive2 

with Flow board:
  https://www.mediawiki.org/w/api.php?action=query&prop=pageprops&titles=Talk:Sandbox

(Note the way we enable Flow on a page is likely to change; editing PHP config files doesn't scale.)
Comment 1 Kunal Mehta (Legoktm) 2014-02-04 04:21:56 UTC
(In reply to comment #0)

> (Note the way we enable Flow on a page is likely to change; editing PHP
> config
> files doesn't scale.)

Is there a bug / discussion somewhere discussing this? The pageprops module that LQT uses just pulls from the page_props table, which is what I think Flow should use as well. If we decide to go down that route, a custom API module won't be needed, it'll just work™.
Comment 2 Oliver Keyes 2014-02-04 09:58:28 UTC
(In reply to comment #1)
> (In reply to comment #0)
> 
> > (Note the way we enable Flow on a page is likely to change; editing PHP
> > config
> > files doesn't scale.)
> 
> Is there a bug / discussion somewhere discussing this? 
Not to my knowledge; it's one of those things where it's dependent on how we want to go about deploying it more widely (not: how we do that technically, but how we do that from a community perspective), and so it's on the back-burner until Flow itself just works™. I invite you to start up a thread on the E2 list, though, because it's a conversation we keep having in fits and starts and never quite finishing.
Comment 3 Brad Jorsch 2014-02-04 15:25:48 UTC
While page_props would be workable, I would lean towards having a "prop=flow" query module that would also allow for returning other flow data related to the page. Unless there is no flow data you can usefully fetch by passing a page title?

e.g. api.php?format=jsonfm&action=query&titles=Foo|Talk:Foo&prop=flow might return something like this:

 {
     "query": {
         "pages": {
             "12345": {
                 "pageid": 12345,
                 "ns": 0,
                 "title": "Foo"
             },
             "12346": {
                 "pageid": 12346,
                 "ns": 1,
                 "title": "Talk:Foo",
                 "flow": {
                        "enabled": true
                 }
             }
         }
     }
 }
Comment 4 Gerrit Notification Bot 2014-02-04 20:30:34 UTC
Change 111255 had a related patch set uploaded by Legoktm:
API: Add prop=flow to detect if Flow is enabled on a page

https://gerrit.wikimedia.org/r/111255
Comment 5 Gerrit Notification Bot 2014-04-22 20:38:13 UTC
Change 111255 merged by jenkins-bot:
API: Add prop=flowinfo to detect if Flow is enabled on a page

https://gerrit.wikimedia.org/r/111255

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links