Last modified: 2014-04-09 07:16:45 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T62799, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 60799 - remove $wgContLang and armourMath
remove $wgContLang and armourMath
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
Math (Other open bugs)
master
All All
: Unprioritized normal (vote)
: ---
Assigned To: Nobody - You can work on this!
: i18n
Depends on:
Blocks: 14202
  Show dependency tree / graph
 
Reported: 2014-02-03 23:21 UTC by physikerwelt
Modified: 2014-04-09 07:16 UTC (History)
15 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---
physik: Backport_to_Stable-

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description physikerwelt 2014-02-03 23:21:06 UTC 
armourMath does:
* Armour rendered math against conversion.
* Escape special chars in parsed math text. (in most cases are img elements)
*
* @param $text String: text to armour against conversion
* @return String: armoured text where { and } have been converted to
* { and }
*/
public static function armourMath( $text ) {
// convert '-{' and '}-' to '-{' and '}-' to prevent
// any unwanted markup appearing in the math image tag.
$text = strtr( $text, array( '-{' => '-{', '}-' => '}-' ) );
return $text;
}
I have to proposals:
A) (the far reaching proposal):
Replace amourMath by using the marker type nowiki
If there are arguments not to remove amourMath the alternative is
B) (remove $wgContLang):
see https://gerrit.wikimedia.org/r/#/c/87519/1
Comment 1 Gerrit Notification Bot 2014-02-03 23:24:15 UTC 
Change 111119 had a related patch set uploaded by Physikerwelt:
remove armourMath

https://gerrit.wikimedia.org/r/111119
Comment 2 Gerrit Notification Bot 2014-02-03 23:25:15 UTC 
Change 87519 had a related patch set uploaded by Physikerwelt:
Remove one $wgContLang usage.

https://gerrit.wikimedia.org/r/87519
Comment 3 physikerwelt 2014-02-04 07:57:01 UTC 
Please be aware that armourMath still belongs to core and not to extension math.
Comment 4 Gerrit Notification Bot 2014-02-04 08:09:56 UTC 
Change 87519 abandoned by Liangent:
Remove one $wgContLang usage.

Reason:
In favor of https://gerrit.wikimedia.org/r/#/c/111119/

https://gerrit.wikimedia.org/r/87519
Comment 5 Gerrit Notification Bot 2014-02-04 08:12:15 UTC 
Change 111119 had a related patch set uploaded by Frédéric Wang:
remove armourMath and wgContLang (bug 60799)

https://gerrit.wikimedia.org/r/111119
Comment 6 Gerrit Notification Bot 2014-02-09 11:56:17 UTC 
Change 111119 abandoned by Physikerwelt:
remove armourMath and wgContLang (bug 60799)

Reason:
restructure changes

https://gerrit.wikimedia.org/r/111119
Comment 7 Gerrit Notification Bot 2014-02-09 12:03:04 UTC 
Change 112324 had a related patch set uploaded by Physikerwelt:
remove armourMath and wgContLang (bug 60799)

https://gerrit.wikimedia.org/r/112324
Comment 8 Gerrit Notification Bot 2014-03-03 05:55:44 UTC 
Change 116458 had a related patch set uploaded by Physikerwelt:
remove armourMath and wgContLang (bug 60799)

https://gerrit.wikimedia.org/r/116458
Comment 9 Gerrit Notification Bot 2014-03-03 05:57:30 UTC 
Change 116458 abandoned by Physikerwelt:
remove armourMath and wgContLang (bug 60799)

Reason:
wrong branch

https://gerrit.wikimedia.org/r/116458
Comment 10 physikerwelt 2014-03-17 08:32:24 UTC 
I think this should go to math 2.0
Please do a code review at
https://gerrit.wikimedia.org/r/#/c/112324/
You can ignore the failed test for now...
Comment 11 Gerrit Notification Bot 2014-04-07 08:48:33 UTC 
Change 112324 merged by Physikerwelt:
remove armourMath and wgContLang (bug 60799)

https://gerrit.wikimedia.org/r/112324
Comment 12 Gerrit Notification Bot 2014-04-07 08:51:27 UTC 
Change 111119 restored by Physikerwelt:
remove armourMath and wgContLang (bug 60799)

https://gerrit.wikimedia.org/r/111119
Comment 13 Gerrit Notification Bot 2014-04-07 08:52:05 UTC 
Change 111119 had a related patch set uploaded by Physikerwelt:
remove armourMath and wgContLang (bug 60799)

https://gerrit.wikimedia.org/r/111119
Comment 14 Gerrit Notification Bot 2014-04-08 11:16:26 UTC 
Change 111119 merged by jenkins-bot:
remove armourMath and wgContLang (bug 60799)

https://gerrit.wikimedia.org/r/111119
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links