Last modified: 2014-02-04 21:05:25 UTC

Wikimedia Bugzilla is closed!

Wikimedia has migrated from Bugzilla to Phabricator. Bug reports should be created and updated in Wikimedia Phabricator instead. Please create an account in Phabricator and add your Bugzilla email address to it.
Wikimedia Bugzilla is read-only. If you try to edit or create any bug report in Bugzilla you will be shown an intentional error message.
In order to access the Phabricator task corresponding to a Bugzilla report, just remove "static-" from its URL.
You could still run searches in Bugzilla or access your list of votes but bug reports will obviously not be up-to-date in Bugzilla.
Bug 60795 - [Regression] Can no longer select the number of changes to show in Special:RecentChanges
[Regression] Can no longer select the number of changes to show in Special:Re...
Product: MediaWiki
Classification: Unclassified
Recent changes (Other open bugs)
All All
: High major (vote)
: 1.23.0 release
Assigned To: Bartosz Dziewoński
: code-update-regression
Depends on:
Blocks: wmf-deployment 39480
  Show dependency treegraph
Reported: 2014-02-03 22:45 UTC by Jackmcbarn
Modified: 2014-02-04 21:05 UTC (History)
4 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Description Jackmcbarn 2014-02-03 22:45:26 UTC
The selector "Show last 50 | 100 | 250 | 500 changes" is currently non-functional. 50 changes are always shown no matter what is selected. This is a regression caused by
Comment 1 Bartosz Dziewoński 2014-02-04 11:11:21 UTC
Where are you seeing this? The 'limit' parameter works correctly for me on master, and I don't see what in the code could make it not work.
Comment 2 Jackmcbarn 2014-02-04 13:26:50 UTC
I can replicate it at currently, as well on my local development environment where I pinpointed it with git bisect.
Comment 3 Kevin Israel (PleaseStand) 2014-02-04 15:00:17 UTC
I can confirm on both translatewiki and my own test wiki. (I created 500 pages using maintenance/edit.php and only 50 show up.)
Comment 4 Kevin Israel (PleaseStand) 2014-02-04 15:30:20 UTC
The problem is that SpecialRecentchanges::getFeedQuery() is called when generating the feed link, causing the limit parameter to be validated against $wgFeedLimit, using the following:

$this->getOptions()->validateIntBounds( 'limit', 0, $wgFeedLimit );

A workaround is to clone the FormOptions object first.
Comment 5 Bartosz Dziewoński 2014-02-04 15:35:00 UTC
Bah, and actually I just recently noticed that this is an issue when writing .
Comment 6 Gerrit Notification Bot 2014-02-04 15:38:37 UTC
Change 111201 had a related patch set uploaded by Bartosz Dziewoński:
Don't override the 'limit' parameter when building feed query
Comment 7 Gerrit Notification Bot 2014-02-04 19:26:15 UTC
Change 111201 merged by jenkins-bot:
Don't override the 'limit' parameter when building feed query
Comment 8 Bartosz Dziewoński 2014-02-04 21:05:25 UTC
No need to backport anything, the troublesome commit was not included in any WMF branch yet.

Note You need to log in before you can comment on or make changes to this bug.