Last modified: 2014-06-09 06:18:03 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T62691, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 60691 - LQT search field disappeared on ptwikibooks
LQT search field disappeared on ptwikibooks
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
LiquidThreads (Other open bugs)
unspecified
All All
: High normal (vote)
: ---
Assigned To: Alex Monk
https://pt.wikibooks.org/wiki/Wikiliv...
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-01-31 19:22 UTC by Helder
Modified: 2014-06-09 06:18 UTC (History)
4 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Helder 2014-01-31 19:22:37 UTC
On
https://www.mediawiki.org/wiki/Extension_talk:UniversalLanguageSelector?uselang=en
the "Search terms:" field is available but for some unknown reason this feature disapeared from Portuguese Wikibooks:
https://pt.wikibooks.org/wiki/Project:LiquidThreads?uselang=en#Opini.C3.B5es.2C_testes_e_relatos_de_bugs

I have no idea when/why this happened.
Comment 1 Chad H. 2014-01-31 19:27:45 UTC
If I had to guess, I'd say it's something related to bug 60439.
Comment 2 Jesús Martínez Novo (Ciencia Al Poder) 2014-01-31 19:34:08 UTC
And even bug 22678
Comment 3 Bawolff (Brian Wolff) 2014-01-31 19:39:53 UTC
You make it sound like a bad thing ;) The search term field has horrible usability. </flippant dig at liquid threads>

--------

Appears to be caused by 8d7f9f8a. Its only enabling the search box if Lucene is an alternative search backend, where it should enable it if Lucene is primary or an alternative backend.
Comment 4 Alex Monk 2014-01-31 19:42:27 UTC
Yep, I think this is my fault. Patch incoming
Comment 5 Gerrit Notification Bot 2014-01-31 19:44:54 UTC
Change 110616 had a related patch set uploaded by Alex Monk:
Fix search bar not being shown

https://gerrit.wikimedia.org/r/110616
Comment 7 Gerrit Notification Bot 2014-01-31 21:29:21 UTC
Change 110616 merged by jenkins-bot:
Fix search bar not being shown

https://gerrit.wikimedia.org/r/110616
Comment 8 Gerrit Notification Bot 2014-01-31 21:31:56 UTC
Change 110633 had a related patch set uploaded by Chad:
Fix search bar not being shown

https://gerrit.wikimedia.org/r/110633
Comment 9 Gerrit Notification Bot 2014-01-31 21:32:21 UTC
Change 110634 had a related patch set uploaded by Chad:
Fix search bar not being shown

https://gerrit.wikimedia.org/r/110634
Comment 10 Gerrit Notification Bot 2014-01-31 21:33:23 UTC
Change 110633 merged by jenkins-bot:
Fix search bar not being shown

https://gerrit.wikimedia.org/r/110633
Comment 11 Gerrit Notification Bot 2014-01-31 21:33:36 UTC
Change 110634 merged by jenkins-bot:
Fix search bar not being shown

https://gerrit.wikimedia.org/r/110634
Comment 12 Alex Monk 2014-01-31 22:40:58 UTC
Deployed by Chad (thank you!)
Comment 13 Helder 2014-02-02 09:50:36 UTC
Will this be live only on Monday?

ptwikibooks is running 1.23wmf11 but I'm still not seeing any element with name="lqt_search" in the page linked above
Comment 14 Alex Monk 2014-02-04 00:25:11 UTC
I messed up the patch which might be why this didn't work - see Gerrit change #110846
Comment 15 Chad H. 2014-02-04 17:44:03 UTC
Should be all fixed now. Sorry about that everyone.
Comment 16 Helder 2014-02-04 18:32:20 UTC
Should the fix(es) be live and the search field be visible at
https://pt.wikibooks.org/wiki/Project:LiquidThreads?uselang=en#Opini.C3.B5es.2C_testes_e_relatos_de_bugs
? I don't see it there...
Comment 17 Chad H. 2014-02-04 18:58:57 UTC
I hate LQT so much.

Can we *please* just merge my patches to it so we can stop this hacky "try to detect lucene search" crud.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links