Last modified: 2014-03-03 05:10:46 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T62550, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 60550 - EventLogging of Echo notifications broken
EventLogging of Echo notifications broken
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
Echo (Other open bugs)
unspecified
All All
: Unprioritized normal (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-01-29 00:44 UTC by Jon
Modified: 2014-03-03 05:10 UTC (History)
19 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Jon 2014-01-29 00:44:32 UTC
According to my graph provided in https://gerrit.wikimedia.org/r/110112
EventLogging of Thanks for both mobile and desktop has been broken since 19th January.
Comment 1 Jon 2014-01-29 00:49:30 UTC
Echo_6081131 doesn't seem to be logging any thanks events.
Comment 2 Jon 2014-01-29 00:55:36 UTC
This may be an issue with Echo and not the Thanks extension...
Comment 3 Kunal Mehta (Legoktm) 2014-01-29 00:58:44 UTC
(In reply to comment #2)
> This may be an issue with Echo and not the Thanks extension...

I don't see anything in Thanks that has to do with EventLogging, so moving to Echo based on https://github.com/wikimedia/mediawiki-extensions-Echo/blob/master/includes/EventLogging.php#L58
Comment 4 Jon 2014-01-29 18:48:22 UTC
So I investigated this somewhat.
If I thank on my local instance I do see an event logged in the Event log but it doesn't show up in the EventLogging database. I had to fiddle with $wgEchoConfig to get this to work.

If I event log on the client side it does show up in the database however. Weird.

Something funny is either happening in efLogServerSideEvent or the configuration on our wikis.

Note this all started on the 9th January which was a Thursday (deployment day).
What got deployed that day?

Event being logged on server on my local instance for a thanks:
{"event":{"version":"1.5","eventId":291,"notificationType":"edit-thank","notificationGroup":"positive","sender":"78","recipientUserId":1,"recipientEditCount":953,"eventSource":"mobilediff","deliveryMethod":"web","revisionId":3823},"schema":"Echo","revision":6081131,"clientValidated":true,"wiki":"my_wiki","recvFrom":"Administrators-MacBook-Air-68.local","timestamp":1391020937,"webHost":"localhost.beta","userAgent":"Mozilla/5.0\u0020(Macintosh;\u0020Intel\u0020Mac\u0020OS\u0020X\u002010_7_5)\u0020AppleWebKit/537.36\u0020(KHTML,\u0020like\u0020Gecko)\u0020Chrome/31.0.1650.63\u0020Safari/537.36"}
Comment 5 bsitu 2014-01-29 18:59:37 UTC
Hey Jon,

There was a similar bug filed in https://bugzilla.wikimedia.org/show_bug.cgi?id=60555.  I asked Dario to look at it in more detail.
Comment 6 Dan Andreescu 2014-01-29 19:46:57 UTC
cc-ing Ori and Nuria, we've all been looking at Event Logging since December.
Comment 7 Ryan Kaldari 2014-01-29 19:55:13 UTC
I generated graphs for mediawiki.org and it looks like Echo logging died there on January 11th:
http://toolserver.org/~kaldari/echo/

Since it died on en.wiki on January 17th, this definitely points to something bad being deployed that week.
Comment 8 Ori Livneh 2014-01-30 09:10:21 UTC
Thanks for the report. This was caused by an update to EventLogging's capsule schema. I have started importing events from the raw logs into the database and expect to have the data recovered within an hour. Are there other server-side events I should restore?
Comment 9 Jon 2014-01-30 19:02:12 UTC
Thanks Ori. I'm not aware of any others. ServerSideAccount creation doesn't seem to have been effected for example.
Comment 10 Jon 2014-01-31 20:56:51 UTC
Ori according to this graph:
http://mobile-reportcard.wmflabs.org/graphs/thanks-daily

This is still not fixed for mobile based events.
On enwiki I just tried thanking an edit but there is no sign of it in the database...
Comment 11 Jon 2014-01-31 20:58:39 UTC
Oh.. just saw bug 60555 which I guess would explain this!
Comment 12 Ori Livneh 2014-02-01 03:34:53 UTC
My intention is to have all events recovered by Wednesday, February 5th. I'll follow up here and on the lists.
Comment 13 Ori Livneh 2014-02-08 02:56:29 UTC
(In reply to comment #12)
> My intention is to have all events recovered by Wednesday, February 5th. I'll
> follow up here and on the lists.

I missed this deadline, sorry. I will get to it this weekend.
Comment 14 nuria 2014-02-08 08:47:48 UTC
Sorry on my side too as I could not get this this week. Will talk with ori over the weekend or Monday(2/10) to coordinate efforts.
Comment 15 Dario Taraborelli 2014-02-12 18:19:49 UTC
Is there an updated ETA on this? On top of the dashboards, this issue is blocking analyses that rely on pure EventLogging data.
Comment 16 Ori Livneh 2014-02-13 01:40:37 UTC
The recovery script is running. It should finish within 24 hours.
Comment 17 Andre Klapper 2014-02-25 15:52:05 UTC
Ori / Nuria: Anything left to do here, or can this ticket be closed?
Comment 18 Ori Livneh 2014-03-03 05:10:46 UTC
(In reply to Andre Klapper from comment #17)
> Ori / Nuria: Anything left to do here, or can this ticket be closed?

Yep. All data has been recovered.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links