Last modified: 2014-01-27 18:16:11 UTC

Wikimedia Bugzilla is closed!

Wikimedia has migrated from Bugzilla to Phabricator. Bug reports should be created and updated in Wikimedia Phabricator instead. Please create an account in Phabricator and add your Bugzilla email address to it.
Wikimedia Bugzilla is read-only. If you try to edit or create any bug report in Bugzilla you will be shown an intentional error message.
In order to access the Phabricator task corresponding to a Bugzilla report, just remove "static-" from its URL.
You could still run searches in Bugzilla or access your list of votes but bug reports will obviously not be up-to-date in Bugzilla.
Bug 60462 - $wgUpgradeKey is not commented out by default
$wgUpgradeKey is not commented out by default
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
Documentation (Other open bugs)
1.22.1
All All
: Low normal (vote)
: ---
Assigned To: Kevin Israel (PleaseStand)
https://www.mediawiki.org/wiki/Manual...
:
Depends on:
Blocks: documentation
  Show dependency treegraph
 
Reported: 2014-01-27 05:46 UTC by Xin Wang
Modified: 2014-01-27 18:16 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Xin Wang 2014-01-27 05:46:42 UTC
As described in manual[1], $wgUpgradeKey should be commented, but LocalSettings.php generated by 1.22.1 installer leaves it uncommented.

Not sure about the behaviour in master and other versions.

[1] http://www.mediawiki.org/wiki/Manual:$wgUpgradeKey
Comment 1 MZMcBride 2014-01-27 07:31:20 UTC
https://git.wikimedia.org/blobdiff/mediawiki%2Fcore.git/31eae6a575c1dea8767ad91181c21db542ab1ced/includes%2Finstaller%2FLocalSettingsGenerator.php

https://git.wikimedia.org/commit/mediawiki%2Fcore.git/31eae6a575c1dea8767ad91181c21db542ab1ced

As far as I can tell, this was intentionally changed by Tim in 2010. Perhaps the mediawiki.org documentation is simply out of date or misleading?
Comment 2 Kevin Israel (PleaseStand) 2014-01-27 16:02:56 UTC
Thanks for reporting this!

Fixed in <https://www.mediawiki.org/w/index.php?title=Manual:$wgUpgradeKey&diff=892002&oldid=629317>.

As far as I can tell, the setting was not commented out in any released
version of MediaWiki, because of r78437 (95f14f01560d), which merged
r78118 (31eae6a575c1) into REL1_17 prior to the 1.17.0 release.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links