Last modified: 2014-01-28 20:25:53 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T62457, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 60457 - Remove deprecated $wgAutopromoteOnce
Remove deprecated $wgAutopromoteOnce
Status: RESOLVED INVALID
Product: MediaWiki
Classification: Unclassified
General/Unknown (Other open bugs)
1.23.0
All All
: Low enhancement (vote)
: ---
Assigned To: Nobody - You can work on this!
aklapper-moreinfo
:
Depends on:
Blocks: 59113
  Show dependency treegraph
 
Reported: 2014-01-27 00:48 UTC by GuyMontag
Modified: 2014-01-28 20:25 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description GuyMontag 2014-01-27 00:48:00 UTC
Per Bug 59113 we looked around the code for things that have been deprecated
and found $wgAutopromoteOnce at includes/DefaultSettings.php:4502
Comment 1 Bawolff (Brian Wolff) 2014-01-28 03:47:36 UTC
Why do you think this is deprecated?
Comment 2 Andre Klapper 2014-01-28 10:26:12 UTC
I'd love to know *why* you think this is deprecated (references for statements are welcome).

[[mw:Manual:$wgAutopromoteOnce]] does not say that this is deprecated (should it use [[mw:Template:Deprecated]]?), and a quick grep shows:

./extensions/FlaggedRevs/FlaggedRevs.setup.php:			$wgAutopromoteOnce['onEdit']['editor'] = $criteria;
./core/includes/DefaultSettings.php:$wgAutopromoteOnce = array(
./core/includes/DefaultSettings.php:$wgAutopromoteOnceLogInRC = true;
./core/includes/Autopromote.php:	 * @param string $event key in $wgAutopromoteOnce (each one has groups/criteria)
./core/includes/Autopromote.php:	 * @see $wgAutopromoteOnce
./core/includes/Autopromote.php:		global $wgAutopromoteOnce;
./core/includes/Autopromote.php:		if ( isset( $wgAutopromoteOnce[$event] ) && count( $wgAutopromoteOnce[$event] ) ) {
./core/includes/Autopromote.php:			foreach ( $wgAutopromoteOnce[$event] as $group => $cond ) {
./core/includes/Autopromote.php:					wfWarn( 'recCheckCondition() given XOR ("^") condition on three or more conditions. Check your $wgAutopromote and $wgAutopromoteOnce settings.' );
./core/includes/User.php:	 * @param string $event key in $wgAutopromoteOnce (each one has groups/criteria)
./core/includes/User.php:	 * @see $wgAutopromoteOnce
./core/includes/User.php:		global $wgAutopromoteOnceLogInRC, $wgAuth;
./core/includes/User.php:				if ( $wgAutopromoteOnceLogInRC ) {


Currently I am tempted to close this report as INVALID. :)
Comment 3 GuyMontag 2014-01-28 20:25:53 UTC
Not actually deprecated. I misinterpreted the comments due to submitting a
series of seven bugs at once. Thanks for letting me know!

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links