Last modified: 2014-10-28 15:47:06 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T62342, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 60342 - [UI] Lightweight toolbars to initialize full toolbars
[UI] Lightweight toolbars to initialize full toolbars
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
WikidataRepo (Other open bugs)
unspecified
All All
: High major (vote)
: ---
Assigned To: Wikidata bugs
u=dev c=frontend p=0
:
Depends on:
Blocks: 54098 60341
  Show dependency treegraph
 
Reported: 2014-01-22 15:16 UTC by tobias.gritschacher
Modified: 2014-10-28 15:47 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description tobias.gritschacher 2014-01-22 15:16:57 UTC
In order to load widgets on demand rather than on page load, a new lightweight toolbar needs to be introduced which then loads the full toolbar and the related widgets when needed.
Comment 1 Henning 2014-10-27 14:36:09 UTC
I would propose closing the ticket after https://gerrit.wikimedia.org/r/#/c/161959/ has been merged. Major toolbar refactorings have been done with that change being the last one in the chain. With all the refactorings applied, the toolbars have become as lightweight as can be. The DOM structure rendered by the back-end is reused completely and no DOM structure unused before triggering any action is generated anymore.
The final enhancement in terms of performance would be to just assign an event to the static buttons rendered by the back-end. However, that would cause major logical implications requiring to considerably restructure the overall toolbar logic.
Comment 2 Henning 2014-10-28 15:47:06 UTC
Just one note: As of https://gerrit.wikimedia.org/r/#/c/167177/, some toolbars (e.g. the statement "edit" toolbars) are not rendered in the static output since they cannot be provided a useful link target.
Consequently, the JS toolbar widgets need to render the DOM structure in JavaScript. In terms of performance, it would be better to always have the back-end render the toolbars--apart from that, there should be sensible link targets for the static toolbars anyhow...

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links