Last modified: 2014-09-25 21:49:46 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T62257, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 60257 - VisualEditor: Add a shortcut for strikethrough (?which?)
VisualEditor: Add a shortcut for strikethrough (?which?)
Status: VERIFIED FIXED
Product: VisualEditor
Classification: Unclassified
Editing Tools (Other open bugs)
unspecified
All All
: Normal enhancement
: VE-deploy-2014-09-18
Assigned To: James Forrester
:
Depends on:
Blocks: ve-keyboardshortcuts
  Show dependency treegraph
 
Reported: 2014-01-20 15:27 UTC by Elitre
Modified: 2014-09-25 21:49 UTC (History)
6 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Elitre 2014-01-20 15:27:17 UTC
Daniel on Mediawiki.org says it uses strikethrough a lot and would like a shortcut for it.
Comment 1 Elitre 2014-01-20 15:32:54 UTC
*he uses
Comment 2 James Forrester 2014-01-22 18:27:58 UTC
Sure. But what short-cut? Remember that it needs to:

* not clash with
** any existing VE shortcut,
** any expected VE shortcut for future uses (e.g. edit image/template/table), or
** any OS or browser shortcut (e.g. Ctrl+C for copy, Cmd+Q for quit);
* be available on most users' keyboards;
* be type-able; and
* ideally be the "standard" shortcut.

This doesn't leave many options. :-(
Comment 3 Elitre 2014-01-23 12:00:24 UTC
I added your comment to Mediawiki.org. 
I think I noticed that the numbers 8 and 9 are still available?
Or at least this is what I read in the new keyboard shortcuts list.
(Which, BTW, is not available for me by its shortcut, since / is located on the numeric pad or above number 7, thus won't work).
Comment 4 Gerrit Notification Bot 2014-09-13 01:03:58 UTC
Change 160174 had a related patch set uploaded by Jforrester:
Add keyboard shortcuts for strikethrough and code annotations

https://gerrit.wikimedia.org/r/160174
Comment 5 Gerrit Notification Bot 2014-09-15 23:21:55 UTC
Change 160174 merged by jenkins-bot:
Add keyboard shortcuts for strikethrough and code annotations

https://gerrit.wikimedia.org/r/160174
Comment 6 Rummana Yasmeen 2014-09-18 18:26:00 UTC
We need to change the shortcut key for code annotation on mac from "cmd+shift+3".Because,its a shortcut to take screenshot so it does not work there.
Comment 7 James Forrester 2014-09-19 00:59:02 UTC
Re-fixed.
Comment 8 Rummana Yasmeen 2014-09-19 18:08:28 UTC
Verified the fix in Betalabs and test2
Comment 9 Rummana Yasmeen 2014-09-25 21:49:46 UTC
Verified the fix in production

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links