Last modified: 2014-01-27 20:30:52 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T62237, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 60237 - textarea #wpTextbox1 overlaps on Internet Explorer 8
textarea #wpTextbox1 overlaps on Internet Explorer 8
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
Interface (Other open bugs)
1.23.0
All All
: Normal trivial (vote)
: 1.23.0 release
Assigned To: Fomafix
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-01-19 19:49 UTC by Fomafix
Modified: 2014-01-27 20:30 UTC (History)
4 users (show)

See Also:
Web browser: Internet Explorer
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
Internet Explorer 8 with browser mode "IE8" (73.72 KB, image/png)
2014-01-19 19:49 UTC, Fomafix
Details
Internet Explorer 8 with browser mode "IE8 compatibility" (71.91 KB, image/png)
2014-01-19 19:52 UTC, Fomafix
Details
Internet Explorer 8 with browser mode "IE8" without IE80Fixes.css (71.80 KB, image/png)
2014-01-19 19:56 UTC, Fomafix
Details
Internet Explorer 8 with browser mode "IE8 compatibility" without IE80Fixes.css (71.90 KB, image/png)
2014-01-19 19:59 UTC, Fomafix
Details

Description Fomafix 2014-01-19 19:49:23 UTC
Created attachment 14341 [details]
Internet Explorer 8 with browser mode "IE8"

The Microsoft Internet Explorer 8 has three compatibility modes:
* Internet Explorer 8
* Internet Explorer 8 compatibility
* Internet Explorer 7
MediaWiki generates standard compatible HTML pages so the default mode is "Internet Explorer 8".

On Internet Explorer 8 with compatibility mode "Internet Explorer 8" the edit textarea #wpTextbox1 is to wide. See attachment.
Comment 1 Fomafix 2014-01-19 19:52:32 UTC
Created attachment 14342 [details]
Internet Explorer 8 with browser mode "IE8 compatibility"

On Internet Explorer 8 with manually activated compatibility mode "Internet Explorer 8 compatibility" the edit textarea #wpTextbox1 has the right width.
Comment 2 Fomafix 2014-01-19 19:56:11 UTC
Created attachment 14343 [details]
Internet Explorer 8 with browser mode "IE8" without IE80Fixes.css

When I empty the file skins/common/IE80Fixes.css the edit textarea #wpTextbox1 has on Internet Explorer 8 with the default compatibility mode "Internet Explorer 8" the right width.
Comment 3 Fomafix 2014-01-19 19:59:03 UTC
Created attachment 14344 [details]
Internet Explorer 8 with browser mode "IE8 compatibility" without IE80Fixes.css

When I empty the file skins/common/IE80Fixes.css and activate manually the compatibility mode "Internet Explorer 8 compatibility" the edit textarea #wpTextbox1 is to wide.
Comment 4 Michael M. 2014-01-20 09:38:10 UTC
commonContent.css has a

#editform textarea {
   display: block;
   -moz-box-sizing: border-box;
   -webkit-box-sizing: border-box;
   box-sizing: border-box;
}

which is interpreted in IE8, and might cause this behavior. So adding a

  box-sizing: content-box;

in IE80Fixes.css might fix this.
Comment 5 Fomafix 2014-01-20 12:13:00 UTC
(In reply to comment #4)

> So adding a
> 
>   box-sizing: content-box;
> 
> in IE80Fixes.css might fix this.

No. box-sizing: content-box is the default value. box-sizing: border-box is here the correct value to generate a textarea with a width of 100% including padding and border.

The CSS property box-sizing is supported in Internet Explorer since version 8: https://developer.mozilla.org/en-US/docs/Web/CSS/box-sizing In compatibility mode the Internet Explorer 8 seams to ignore the property box-sizing for compatibility.

The definition in IE80Fixes.css disturbs the correct working Internet Explorer 8 in the default standard compliance mode. In attachment 14343 [details] you can see that the width of the box is correct when IE80Fixes.css is empty. But an empty IE80Fixes.css generates a overflowing box in compatibility mode of Internet Explorer 8. Maybe it is not possible to fix in both modes.

WikiEditor avoids the problem by using
.wikiEditor-ui textarea#wpTextbox1 {
  border-left: none;
  boder-right: none;
  padding-left: 0;
  padding-right: 0;
}
so content-box and border-box has the same width.

IE80Fixes.css is supposed to fix the bug 19334. I can not reproduce the problems described in bug 19334. I think the workaround in IE80Fixes.css generates more problems than it solves problems.
Comment 6 Bartosz Dziewoński 2014-01-20 15:48:40 UTC
CC-ing author of the hack.
Comment 7 Gerrit Notification Bot 2014-01-27 14:10:12 UTC
Change 109660 had a related patch set uploaded by Gerrit Patch Uploader:
Remove IE80Fixes.css

https://gerrit.wikimedia.org/r/109660
Comment 8 Bartosz Dziewoński 2014-01-27 20:28:21 UTC
Thanks!
Comment 9 Gerrit Notification Bot 2014-01-27 20:30:52 UTC
Change 109660 merged by jenkins-bot:
Remove IE80Fixes.css

https://gerrit.wikimedia.org/r/109660

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links