Last modified: 2006-09-29 20:14:54 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T8023, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 6023 - wl_notificationtimestamp NULL check but wl_notificationtimestamp is '0'
wl_notificationtimestamp NULL check but wl_notificationtimestamp is '0'
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
General/Unknown (Other open bugs)
1.8.x
All All
: Normal normal (vote)
: ---
Assigned To: Nobody - You can work on this!
: patch
: 7442 (view as bug list)
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2006-05-19 21:57 UTC by Marcus Hüwe
Modified: 2006-09-29 20:14 UTC (History)
1 user (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
patch which fixes the "problem" (488 bytes, patch)
2006-05-19 21:58 UTC, Marcus Hüwe
Details

Description Marcus Hüwe 2006-05-19 21:57:23 UTC
In the function clearAllNotifications in includes/User.php
'wl_notificationtimestamp' => 0 must be changed to 
'wl_notificationtimestamp' => NULL
because otherwise the mysql-check in the notifyOnPageChange() function in
includes/UserMailer.php does not work (checks for NULL and not for '0').
I think it's a bug so i attached a patch for it.
Comment 1 Marcus Hüwe 2006-05-19 21:58:09 UTC
Created attachment 1795 [details]
patch which fixes the "problem"
Comment 2 Brion Vibber 2006-09-29 19:56:28 UTC
*** Bug 7442 has been marked as a duplicate of this bug. ***
Comment 3 Jimmy Collins 2006-09-29 20:14:54 UTC
Fixed in r16696.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links