Last modified: 2014-04-11 19:49:22 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T61913, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 59913 - Preferences and address should be separated from content in footer of HTML email notifications
Preferences and address should be separated from content in footer of HTML em...
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
Echo (Other open bugs)
master
All All
: Unprioritized normal (vote)
: ---
Assigned To: Quim Gil
: design
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-01-10 18:20 UTC by Quim Gil
Modified: 2014-04-11 19:49 UTC (History)
11 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
Screenshot of proposed notification, after removing all the "bgcolor=3D"#F8F8F8" (56.41 KB, image/png)
2014-01-10 19:20 UTC, Quim Gil
Details

Description Quim Gil 2014-01-10 18:20:01 UTC
Today I got my first Flow notification, yay!

I was surprised by the last line, though:

"Wikimedia Foundation, 149 New Montgomery St., 3rd Fl., San Francisco, CA 94105, USA"

Do we really need this? Are we adding this information in any other notification coming from Wikimedia projects?

Also, is this line hardcoded and therefore a problem for any 3rd party MediaWiki using Flow in the future?

As a Wikimedia contributors I think it gives an unnecessary impression of an official and centralized organization, kind of being in the way of my communications from/to other contributors.

It felt weird to me while being an employee of the WMF, sitting in that exact address and being replied from a project (mediawiki.org) where the Foundation is heavily invested. I can see how weirder will it feel for users of e.g. Catalan Wikipedia when communicating between them thousands of miles away from "149 New Montgomery St..."

I know some corporations do this to the extent that we are almost blind to tese disclaimers but, as opposed to us, they are centralized organizations obsessed about branding, copyrights, and terms & conditions.
Comment 1 Oliver Keyes 2014-01-10 18:24:23 UTC
It's nothing to do with branding, copyrights or terms and conditions, it's to do with legal obligations as to how we identify that we're sending people tons of emails and who they can complain to ;p. We reviewed it with Legal, they insisted on adding it, and it's part of every other notification (Flow or no) that comes via your inbox.
Comment 2 Quim Gil 2014-01-10 19:20:33 UTC
Created attachment 14283 [details]
Screenshot of proposed notification, after removing all the "bgcolor=3D"#F8F8F8"

Mmmok. Not that fast, though.

Is this address hardcoded or is it configurable?

Also a proposal: keep everything as it is but remove that "bgcolor=3D"#F8F8F8" from the related td's. Screenshot attached.

After checking in my mailbox the notifications of Facebook, Twitter, LinkedIn, Change.org, Wired, Amazon, and some more it is clear that

* All have the address at the end, yes

* All have the preferences and address information clearly separated from the content, on top of the default gray of the email client (while the content is usually on top of white) and some even have the address in a lighter grey color.

On a second look, now I realize that the preferences and address in the Flow notification are on a grey background. In order to see this I had to tilt my screen, otherwise it looks just as white as the white background of the notification.
Comment 3 Oliver Keyes 2014-01-10 19:26:38 UTC
I imagine configurable, but I can't say for certain. In any case, that (and UI tweaks) are Echo rather than Flow problems - I'll move the bug accordingly, but you should be aware that Echo is currently a 'if it breaks, fix it, otherwise it can wait' product.
Comment 4 Quim Gil 2014-01-10 19:31:15 UTC
Thank you. I can file a patch for that simple color fix as soon as I have time to see where that piece of code is sitting.
Comment 5 Quim Gil 2014-01-10 19:33:13 UTC
Having a designer looking at the screenshot and saying "yep, good idea" would help.  :)
Comment 6 Oliver Keyes 2014-01-10 19:43:44 UTC
Poke benny on IRC; he should know :)
Comment 7 Gerrit Notification Bot 2014-01-14 06:39:19 UTC
Change 107328 had a related patch set uploaded by Qgil:
Remove background color of footer in email notifications

https://gerrit.wikimedia.org/r/107328
Comment 8 Kunal Mehta (Legoktm) 2014-01-30 07:50:26 UTC
(In reply to comment #5)
> Having a designer looking at the screenshot and saying "yep, good idea" would
> help.  :)

CC'ing Jared. 

The patch looks fine to me and I'll merge it after a while if there are no objections.
Comment 9 Jared Zimmerman (WMF) 2014-01-30 08:33:10 UTC
Both lines should be centered it just looks weird to have two lines of left aligned text in a block that is centered. If that is resolved I'm fine with it.
Comment 10 Quim Gil 2014-01-30 22:55:52 UTC
Note that the only thing this patch is doing is removing the background color of the Preferences and address. It should be showing exactly the same alignment used currently in Echo notifications.
Comment 11 Gerrit Notification Bot 2014-04-07 23:49:44 UTC
Change 107328 merged by jenkins-bot:
Remove background color of footer in email notifications

https://gerrit.wikimedia.org/r/107328

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links