Last modified: 2014-06-18 16:45:31 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T61893, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 59893 - Remove padlock icon from links in Wikimedia Bugzilla installation
Remove padlock icon from links in Wikimedia Bugzilla installation
Status: RESOLVED FIXED
Product: Wikimedia
Classification: Unclassified
Bugzilla (Other open bugs)
wmf-deployment
All All
: Low enhancement (vote)
: ---
Assigned To: Tony Thomas
: easy
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-01-10 04:00 UTC by MZMcBride
Modified: 2014-06-18 16:45 UTC (History)
5 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description MZMcBride 2014-01-10 04:00:44 UTC
I think the padlock icon should be removed from links in the Wikimedia Bugzilla installation. Comments such as bug 27841 comment 7 look super Christmas tree-y.
Comment 2 Gerrit Notification Bot 2014-01-10 19:02:51 UTC
Change 106761 had a related patch set uploaded by 01tonythomas:
Remove padlock icon from links in Wikimedia Bugzilla installation

https://gerrit.wikimedia.org/r/106761
Comment 3 Daniel Zahn 2014-01-13 10:23:47 UTC
is everything https already? then it seems indeed unneeded, but if it's not i guess the original intention was to tell users which links are save?
Comment 4 Andre Klapper 2014-01-13 13:09:46 UTC
The custom vector.css file in Bugzilla predates my existence in this community, but as the name implies it tries to make Bugzilla look more like MediaWiki Vector style, and Vector displays the padlock icon next to secure links.

Personally I'm undecided if we're after better readability in Bugzilla or higher consistency with MediaWiki for how text is rendered.
Comment 5 MZMcBride 2014-01-14 06:12:46 UTC
(In reply to comment #4)
> Personally I'm undecided if we're after better readability in Bugzilla or
> higher consistency with MediaWiki for how text is rendered.

Instead of removing the padlock icon, I suppose we could add a subsequent CSS directive that says that if it a link starts with "https://www.mediawiki.org/" or "https://bugzilla.wikimedia.org/" it could be treated as an internal link (i.e., no HTTPS icon). That's really the issue here: certain links such as [[internal links]] shouldn't have HTTPS icons because that doesn't match the wiki's behavior and it looks really weird.
Comment 6 Andre Klapper 2014-03-28 12:56:16 UTC
I don't want to decide on taking this patch or not (see comment 4). 
Please gather more voices / input.
Comment 7 MZMcBride 2014-05-14 02:01:51 UTC
Thanks for noting bug 61178 as a see also here. That bug is now resolved/fixed.
Comment 8 Gerrit Notification Bot 2014-06-18 16:43:54 UTC
Change 106761 merged by Dzahn:
Remove padlock icon from links in Wikimedia Bugzilla installation

https://gerrit.wikimedia.org/r/106761
Comment 9 Daniel Zahn 2014-06-18 16:45:31 UTC
icons are gone on reload now

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links