Last modified: 2014-10-02 21:04:37 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T61853, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 59853 - Should say "Thanks" instead of "OK" in confirmation dialog
Should say "Thanks" instead of "OK" in confirmation dialog
Status: RESOLVED INVALID
Product: MediaWiki extensions
Classification: Unclassified
Thanks (Other open bugs)
unspecified
All All
: Normal trivial (vote)
: ---
Assigned To: Nobody - You can work on this!
: easy
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2014-01-09 02:13 UTC by Luis Villa (WMF Legal)
Modified: 2014-10-02 21:04 UTC (History)
7 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Luis Villa (WMF Legal) 2014-01-09 02:13:25 UTC 
This is cosmetic, but OK/Cancel dialog boxes are really Not Cool (tm), because there is some extra cognitive load in figuring out what "OK" does. All the major platform's user interface guidelines recommend labeling buttons with active verbs relevant to the action - in this case "Thanks". 

[An action this harmless should not even have a confirmation dialog, just undo instead. But I realize having an undo option is probably a lot of work, so not going to file that request now.]
Comment 1 Kunal Mehta (Legoktm) 2014-01-09 02:21:23 UTC 
So something like "Send thanks" / "Cancel"?
Comment 2 Luis Villa (WMF Legal) 2014-01-09 02:24:54 UTC 
Could be simply "Thank" / "Cancel", since thank is an action verb.
Comment 3 Anjana S 2014-01-12 16:04:00 UTC 
I would like to work on this bug.Can someone please assign this to me.
Comment 4 Bartosz Dziewoński 2014-01-12 16:05:43 UTC 
It is okay to work on unassigned bugs without having them assigned to you.
(That's in fact what we usually do.)
Comment 5 Anjana S 2014-01-14 05:20:13 UTC 
Yea ! I have started working on this bug by cloning the extension and stuffs to my localhost.But I'm not able to figure out the exact position of this bug.Can someone please help me by providing a link regarding this or a screenshot may be helpful.
Comment 6 Tony Thomas 2014-01-14 05:37:29 UTC 
> someone please help me by providing a link regarding this or a screenshot may
> be helpful.
Firstly, you need to install the Thanks extensions as given here 
http://www.mediawiki.org/wiki/Extension:Thanks
Then Check the Usage section to find out How to give 'Thanks' to a user. You will find out the confirmation box then.
Comment 7 Gerrit Notification Bot 2014-01-14 10:50:59 UTC 
Change 107350 had a related patch set uploaded by 01tonythomas:
Changed "OK" to "Thank" in confirmation dialog box

https://gerrit.wikimedia.org/r/107350
Comment 8 Anjana S 2014-01-14 13:27:29 UTC 
I have resubmitted the patch for review.Does this patch looks ok?
Comment 9 Anjana S 2014-01-15 15:32:28 UTC 
I submitted my patch again.Does this looks ok?
Comment 10 Gerrit Notification Bot 2014-09-19 01:15:12 UTC 
Change 107350 abandoned by Legoktm:
Changed "OK" to "Thank" in confirmation dialog box

Reason:
No progress since January, feel free to restore this patch by pressing "restore".

https://gerrit.wikimedia.org/r/107350
Comment 11 Jared Zimmerman (WMF) 2014-10-02 21:04:37 UTC 
The confirmation dialog is no longer in use, now an in-line action is used instead to be mobile friendly. This should all still be replaced with https://bugzilla.wikimedia.org/show_bug.cgi?id=69636
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links