Last modified: 2014-06-11 13:26:24 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T61845, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 59845 - WikiEditor: jQuery UI stylesheet refers to nonexistant ui-bg_*.png images
WikiEditor: jQuery UI stylesheet refers to nonexistant ui-bg_*.png images
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
WikiEditor (Other open bugs)
master
All All
: Normal normal (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on: 60077
Blocks:
  Show dependency treegraph
 
Reported: 2014-01-09 00:20 UTC by T. Gries
Modified: 2014-06-11 13:26 UTC (History)
5 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description T. Gries 2014-01-09 00:20:14 UTC
Extension works, but the server log file shows access errors for non-existing image files:

wiki/images/ui-bg_flat_75_ffffff_40x100.png, referer: http://wiki/e/index.php?title=test&action=edit

wiki/images/ui-bg_highlight-soft_75_cccccc_1x100.png, referer: http://wiki/e/index.php?title=test&action=edit

wiki/images/ui-bg_glass_75_e6e6e6_1x400.png, referer: http://wiki/e/index.php?title=test&action=edit


* latest MediaWiki core version of today (2014-01-08)
* latest E:WikiEditor version
Comment 1 Derk-Jan Hartman 2014-04-07 14:28:08 UTC
This is a problem in (our version of) jQuery UI, which is used by the dialogs mode of WikiEditor
Comment 2 T. Gries 2014-04-07 18:01:03 UTC
(In reply to Derk-Jan Hartman from comment #1)
> This is a problem in (our version of) jQuery UI, which is used by the
> dialogs mode of WikiEditor

This was fully clear. It needs urgently to be fixed by WikiEditor developers.
Comment 3 Andre Klapper 2014-04-08 10:39:33 UTC
Could you elaborate why this is suddenly "urgent" after three months?
Comment 4 T. Gries 2014-04-08 16:46:19 UTC
(In reply to Andre Klapper from comment #3)
> Could you elaborate why this is suddenly "urgent" after three months?

André, yes.

I waited until these "header already sent" problem was fixed, which also spoilt my server log files. Now, these missing-image messages are spoiling my server log files since January, and I think this is a bad situation which the WikiEditor extension coders have to solve with a higher than average priority.

Spoiling log files and knowning the reason is not good behavior of an extension.

I can understand, that you perhaps don't like my harsh tone, sorry for that, but I also don't like fiddling around with priorities.
Comment 5 Derk-Jan Hartman 2014-04-08 16:50:18 UTC
"This was fully clear". Then you should have added it. It would have saved me 10 mins of triage time.
Comment 6 T. Gries 2014-04-08 16:53:40 UTC
(In reply to Derk-Jan Hartman from comment #5)
> "This was fully clear". Then you should have added it. It would have saved
> me 10 mins of triage time.

Derk-Jan, can you fix this? It would be nice. Groetjes.
Comment 7 Derk-Jan Hartman 2014-04-08 17:13:01 UTC
This only occurs when using a skin !== Vector
Comment 8 T. Gries 2014-04-08 17:32:49 UTC
(In reply to Derk-Jan Hartman from comment #7)
> This only occurs when using a skin !== Vector

Confirmed: we use monobook, and want to stick to that.
Comment 9 Derk-Jan Hartman 2014-04-08 17:34:39 UTC
The problem disappears when running with debug=true

Inspection learns that this seems to be a problem with the CSS processor of ResourceLoader. It fails to rewrite some CSS rules.

Specifically it seems to be with lines of the type:

background: #ffffff/*{bgColorActive}*/ url(images/ui-bg_glass_65_ffffff_1x400.png)/*{bgImgUrlActive}*/ 50%/*{bgActiveXPos}*/ 50%/*{bgActiveYPos}*/ repeat-x/*{bgActiveRepeat}*/;
Comment 10 Bartosz Dziewoński 2014-06-10 21:36:37 UTC
Will be fixed by MediaWiki 1.24.
Comment 11 Krinkle 2014-06-11 13:23:51 UTC
Rephrased as calling this a server error is confusing.
Comment 12 Krinkle 2014-06-11 13:26:24 UTC
Relevant changes:

> CSSMin: Fix bug in url() value remapping
>
> Bug: 60077
> Change-Id: Ife00d01b78c6369f20ffc49d20aa58e354a61ee7

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links