Last modified: 2014-03-01 05:50:22 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T61699, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 59699 - Better spinner icon for jquery.spinner.js
Better spinner icon for jquery.spinner.js
Status: PATCH_TO_REVIEW
Product: MediaWiki
Classification: Unclassified
JavaScript (Other open bugs)
1.23.0
All All
: Normal normal (vote)
: ---
Assigned To: Nobody - You can work on this!
: easy
Depends on:
Blocks: hidpi
  Show dependency tree / graph
 
Reported: 2014-01-05 22:51 UTC by MZMcBride
Modified: 2014-03-01 05:50 UTC (History)
10 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Screenshot of throbber from media viewer in BetaFeatures (22.48 KB, image/png)
2014-01-05 22:51 UTC, MZMcBride 		Details
Another kind of spinner (6.12 KB, image/gif)
2014-01-14 06:38 UTC, Tina Johnson ( tinaj1234 ) 		Details
Add an attachment (proposed patch, testcase, etc.)

Description MZMcBride 2014-01-05 22:51:48 UTC 
Created attachment 14229 [details]
Screenshot of throbber from media viewer in BetaFeatures

The media viewer throbber in the BetaFeatures extension appears to be low resolution and looks kind of bad. Screenshot attached.
Comment 1 MZMcBride 2014-01-12 09:13:44 UTC 
It's called a spinner in the code. :-)
Comment 2 MZMcBride 2014-01-13 03:43:15 UTC 
Mark: did this get fixed? I think the throbber/spinner may be gone now (I looked at mediawiki.org briefly and it didn't seem to be there).
Comment 3 Mark Holmquist 2014-01-14 00:15:33 UTC 
It got "fixed" but only in that we don't use this library anymore. In core, we should fix the bug more resolutely by using APNG or just a properly alpha'd GIF. Test on a variety of coloured backgrounds to make sure.
Comment 4 Mark Holmquist 2014-01-14 00:17:18 UTC 
Note: The library in question is resources/jquery/jquery.spinner.js - the files that need changing are resources/jquery/images/spinner.gif and resources/jquery/images/spinner-large.gif - just so you know where to go :)
Comment 5 MZMcBride 2014-01-14 02:14:53 UTC 
[[mw:User:Splarka/Throbber]]

If this bug report is only about MediaWiki core's generic throbber, this is probably a duplicate.
Comment 6 Tina Johnson ( tinaj1234 ) 2014-01-14 06:38:45 UTC 
Created attachment 14304 [details]
Another kind of spinner

Was wondering if we could go for another kind of spinner ? Not necessarily this.
Comment 7 Tisza Gergő 2014-02-11 19:23:06 UTC 
Oops, sorry. Just wanted to rename it.
Comment 8 Gerrit Notification Bot 2014-02-28 14:19:02 UTC 
Change 116103 had a related patch set uploaded by Deepali:
Add better spinner icon for jquery.spinner.js

https://gerrit.wikimedia.org/r/116103
Comment 9 Gerrit Notification Bot 2014-03-01 05:50:22 UTC 
Change 116225 had a related patch set uploaded by Deepali:
Add vector svg animated spinner icon

https://gerrit.wikimedia.org/r/116225
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links