Last modified: 2014-01-30 09:16:24 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T61239, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 59239 - Autonym name for personal toolbar position under baseline
Autonym name for personal toolbar position under baseline
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
UniversalLanguageSelector (Other open bugs)
unspecified
All All
: High normal (vote)
: ---
Assigned To: Niklas Laxström
:
: 58244 (view as bug list)
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-01-03 03:26 UTC by Erik Moeller
Modified: 2014-01-30 09:16 UTC (History)
12 users (show)

See Also:
Web browser: Google Chrome
Mobile Platform: ---
Assignee Huggle Beta Tester: ---
siebrand: Backport_WMF+


Attachments
Screenshot (cropped) demonstrating alignment issue (6.22 KB, image/png)
2014-01-03 03:27 UTC, Erik Moeller
Details

Description Erik Moeller 2014-01-03 03:26:46 UTC
ULS is incorrectly positioned in wmf9 (currently deployed on mediawiki.org), see screenshot, taken in Chrome/Ubuntu.
Comment 1 Erik Moeller 2014-01-03 03:27:19 UTC
Created attachment 14216 [details]
Screenshot (cropped) demonstrating alignment issue
Comment 2 Kunal Mehta (Legoktm) 2014-01-03 03:40:22 UTC
Might be caused by bug 59234 making the little person icon disappear?
Comment 3 Andre Klapper 2014-01-03 11:20:35 UTC
Confirming in Chrome 31; no problem in Firefox 26. 
Adding tentative dependency.
Comment 4 Niklas Laxström 2014-01-03 13:42:41 UTC
I don't think this is related to bug 59234. This issue is present since dfc40c8f59ca428c9c672a8c8ee9d6f36076a6c0 in ULS which adds autonym class for the trigger.

This causes it to set the height of the text to 14px instead of the 13px of other elements there and misalign it. The issues is present in Chrome 28-32 (all I could test easily) but not in Chrome 16. There is no easily detectable misaglignment in other browsers.
Comment 5 Niklas Laxström 2014-01-03 20:22:20 UTC
Someone please explain why this issue – misaligment of an element by a couple of pixels, observed only in one browser, having been present for two months – is categorized as a blocker.

Blocker severity is defined as follow (depending on which site you read):
1) Blocks further development and/or testing work.
2) Prevents function from being used, no work-around, blocking progress on multiple fronts
Comment 6 Nemo 2014-01-03 20:40:40 UTC
(In reply to comment #5)
> Someone please explain why this issue – misaligment of an element by a couple
> of pixels, observed only in one browser, having been present for two months –
> is categorized as a blocker.

Probably due to the connection to bug 59234 which is marked as blocking bug 38865. Given comment 4 the assessment looks superseded.
Comment 7 Erik Moeller 2014-01-03 21:11:34 UTC
Looking more closely, the ULS alignment issue on mediawiki.org is indeed exacerbated by bug 59234, due to the user icon no longer showing up. The alignment issue itself is not new, and not a blocker for wmf9, though we should still fix it soon as it's an annoying layout discrepancy.
Comment 8 Siebrand Mazeland 2014-01-06 07:33:12 UTC
This issie is tracked in mingle as https://wikimedia.mingle.thoughtworks.com/projects/language_engineering/cards/3941
Comment 9 Gerrit Notification Bot 2014-01-06 08:04:20 UTC
Change 105643 had a related patch set uploaded by Nikerabbit:
Fix alignment issue of uls trigger

https://gerrit.wikimedia.org/r/105643
Comment 10 Gerrit Notification Bot 2014-01-06 08:17:18 UTC
Change 105643 merged by jenkins-bot:
Fix alignment issue of ULS trigger

https://gerrit.wikimedia.org/r/105643
Comment 11 Siebrand Mazeland 2014-01-06 08:18:54 UTC
From commit summary: The calculated font-height is about 13.5px on Niklas's machine. For some reason the usage of Autonym font sways the rounding of the container height to 14px instead of 13px as for other items. He found out that setting line-height to 1em or 100% makes the trigger size also rounds to 13px, but he can't explain why. He didn't see any change in Modern or Monobook skins.
Comment 12 Gerrit Notification Bot 2014-01-06 12:28:41 UTC
Change 105670 had a related patch set uploaded by Siebrand:
Fix alignment issue of ULS trigger

https://gerrit.wikimedia.org/r/105670
Comment 13 Gerrit Notification Bot 2014-01-07 08:05:49 UTC
Change 105670 merged by jenkins-bot:
Fix alignment issue of ULS trigger

https://gerrit.wikimedia.org/r/105670
Comment 14 Amir E. Aharoni 2014-01-30 09:16:24 UTC
*** Bug 58244 has been marked as a duplicate of this bug. ***

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links