Last modified: 2014-09-08 23:15:55 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T61155, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 59155 - Flow: Remove font-related formatting from board header area
Flow: Remove font-related formatting from board header area
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
Flow (Other open bugs)
unspecified
All All
: Normal normal (vote)
: ---
Assigned To: Nobody - You can work on this!
: easy
: 60786 (view as bug list)
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-12-31 02:23 UTC by Quiddity
Modified: 2014-09-08 23:15 UTC (History)
6 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Quiddity 2013-12-31 02:23:52 UTC
Per Fram's comment and S's reply, the '''*All Bold*''' text in the Board Header looks bad for anything longer than a short sentence, and for most templates.
https://www.mediawiki.org/w/index.php?title=Talk:Sandbox&workflow=050c27a75b2dcc146adc842b2b77e796#flow-post-050c27ab1f07dae40bd7842b2b77d26b

It also doesn't preview correctly, because it's being added post-save.

Please either change the default by removing the forced-bold styling (preferred), or provide a reliable solution (CSS class?) that can be very widely used (ie by ALLLL current talkpage templates).
Comment 1 Bingle 2013-12-31 02:42:24 UTC
The WMF core features team tracks this bug on Mingle card https://mingle.corp.wikimedia.org/projects/flow/cards/666, but people from the community are welcome to contribute here and in Gerrit.
Comment 2 Maryana Pinchuk 2014-01-14 17:45:06 UTC
We'll remove the bold for now and in the future investigate adding more complex heuristics for identifying template vs. freeform text (which looks strange in the header area if it's completely unstyled).
Comment 3 Gerrit Notification Bot 2014-01-23 01:00:49 UTC
Change 109029 had a related patch set uploaded by SG:
Do not apply font styles on non-plain-text headers

https://gerrit.wikimedia.org/r/109029
Comment 4 Gerrit Notification Bot 2014-01-27 10:48:48 UTC
Change 109029 merged by jenkins-bot:
Do not apply font styles on non-plain-text headers

https://gerrit.wikimedia.org/r/109029
Comment 5 Quiddity 2014-02-03 22:03:49 UTC
*** Bug 60786 has been marked as a duplicate of this bug. ***
Comment 6 MZMcBride 2014-02-03 22:09:06 UTC
(In reply to comment #4)
> Change 109029 merged by jenkins-bot:
> Do not apply font styles on non-plain-text headers
> 
> https://gerrit.wikimedia.org/r/109029

What's the status of this bug report? (Should it still be marked as PATCH_TO_REVIEW?)

And what's the status of this changeset? (Is it deployed to the English Wikipedia?)
Comment 7 Maryana Pinchuk 2014-02-03 22:33:33 UTC
*** Bug 60786 has been marked as a duplicate of this bug. ***
Comment 8 Maryana Pinchuk 2014-02-03 22:35:34 UTC
Patch to partially remove styling was merged on mw.org (you can see it here: https://www.mediawiki.org/wiki/Talk:Flow), but it's clearly still looking pretty weird, so we'll go ahead and remove all the styling from that area along with a bunch of other frontend styling fixes this next couple of weeks.
Comment 9 spage 2014-02-04 07:03:38 UTC
(In reply to comment #8)
> Patch to partially remove styling...

more precisely, the CSS in Gerrit change #109029 only styles "simple" paragraphs in the header. If you put stuff in a div or a table, it's left alone. But the header on Talk:Flow is some simple text plus some bullets, so the former is styled gray and bold, and the bullets aren't. It's tricky to do the right thing.
Comment 10 Danny Horn 2014-09-08 23:15:55 UTC
Resolving this; I believe we're not adding any extra styling to the board header now.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links